Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separates setters inside Articulation for joint position and velocity #1751

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mayankm96
Copy link
Contributor

@Mayankm96 Mayankm96 commented Jan 30, 2025

Description

Previously in the Articulation class, there was a single method for setting joint state. However, it is desirable at times to only set joint position or velocity. For instance, for randomization events that pushes a joint by adding a random velocity to it.

This MR separates the write_joint_state_to_sim into separate setters for joint positions and joint velocities. This goes inline with the method to set root pose, root velocity or the root state.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 added the enhancement New feature or request label Jan 30, 2025
Copy link
Collaborator

@jtigue-bdai jtigue-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some NITs on units

"""Write joint velocities to the simulation.

Args:
velocity: Joint velocities. Shape is (len(env_ids), len(joint_ids)).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
velocity: Joint velocities. Shape is (len(env_ids), len(joint_ids)).
velocity: Joint velocities (rad/s). Shape is (len(env_ids), len(joint_ids)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Velocities are rad/s for revolute and m/s for prismatic?

"""Write joint positions to the simulation.

Args:
position: Joint positions. Shape is (len(env_ids), len(joint_ids)).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
position: Joint positions. Shape is (len(env_ids), len(joint_ids)).
position: Joint positions (rad). Shape is (len(env_ids), len(joint_ids)).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image I found some reference in Physx about joint units hope this is useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants