-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separates setters inside Articulation for joint position and velocity #1751
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some NITs on units
"""Write joint velocities to the simulation. | ||
|
||
Args: | ||
velocity: Joint velocities. Shape is (len(env_ids), len(joint_ids)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
velocity: Joint velocities. Shape is (len(env_ids), len(joint_ids)). | |
velocity: Joint velocities (rad/s). Shape is (len(env_ids), len(joint_ids)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Velocities are rad/s for revolute and m/s for prismatic?
"""Write joint positions to the simulation. | ||
|
||
Args: | ||
position: Joint positions. Shape is (len(env_ids), len(joint_ids)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
position: Joint positions. Shape is (len(env_ids), len(joint_ids)). | |
position: Joint positions (rad). Shape is (len(env_ids), len(joint_ids)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Previously in the Articulation class, there was a single method for setting joint state. However, it is desirable at times to only set joint position or velocity. For instance, for randomization events that pushes a joint by adding a random velocity to it.
This MR separates the
write_joint_state_to_sim
into separate setters for joint positions and joint velocities. This goes inline with the method to set root pose, root velocity or the root state.Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there