Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes instructions on importing ANYmal URDF in docs #1915

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

Mayankm96
Copy link
Contributor

@Mayankm96 Mayankm96 commented Feb 20, 2025

Description

Previously, the ANYmal URDF importer example was setting the stiffness and damping to new defaults (100.0 and 0.1 respectively). However, this is undesirable as we want to import the asset with no stiffness and damping (as we do effort control). This MR corrects the instructions to convert ANYmal asset.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 added bug Something isn't working documentation Improvements or additions to documentation labels Feb 20, 2025
@Mayankm96 Mayankm96 merged commit 35b04a9 into main Feb 20, 2025
4 of 5 checks passed
@Mayankm96 Mayankm96 deleted the fix/urdf-import-erdoc branch February 20, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant