Fix s1_orbit
to use ASF S3 orbit source
#142
Open
+411
−447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scihub has been broken, leading to broken functionality for
s1_orbit1
. This is also breaking local COMPASS use due to opera-adt/COMPASS#226You should be able to run (random SAFE name):
and get
S1A_OPER_AUX_POEORB_OPOD_20240922T070612_V20240901T225942_20240903T005942.EOF
This takes the idea from scottstanie/sentineleof#66 to use the new ASF public orbit source.
Removed:
• The global Scihub credentials
• Functions that queried the Copernicus GNSS API (check_internet_connection, _get_orbit_dict, _download_orbit_file)
Added/Updated:
exist
check: we just parse the name for start/stop dates, so we don't need an actual file.This should “fix” the broken module by removing the dead Scihub parts while still providing the previous functionality using the new ASF S3 service.
I've tried to keep as much old stuff as possible, but I'm not 100% clear which portions are necessary for current OPERA production and which are handled by the PCM staging logic. I'm most unsure around the concatenation logic.
Closes #3