Prevent circular references (for comment/feedback) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming this goes a bit further than #49 |
|
I also have a follow-on for this PR which adds support for inherited schema blocks. |
Blocked by tracking already-serialized resources in context
DougPuchalski
force-pushed
the
feature/block-circular-refs
branch
from
26ab1d4 to
4aaac73
Compare
| return if collection.nil? || collection.empty? | ||
| context_options ||= {} |
There was a problem hiding this comment.
If the content_options argument default value is nil, this line will always resolve to {}. So keeping the default value as {} means this line is not necessary.
There was a problem hiding this comment.
The default only takes effect when the arg is not supplied. The intention is for context_options to be {} even if the argument is passed in explicitly as nil.
There was a problem hiding this comment.
I see, that makes sense. Thanks for clarifying.
|
Friendly ping ⛵ What steps are required to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted for comments, feedback for general usefulness.
For my app I had issues serializing resources that link to each other. This would cause infinite recursion.
This PR leverages the context to block resources have already been serialized.