Skip to content

Commit

Permalink
remove metrics due to sample limit
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Tay committed Jan 2, 2025
1 parent ed49448 commit 5964a96
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions admiral/pkg/clusters/serviceentry.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ import (
commonUtil "github.com/istio-ecosystem/admiral/admiral/pkg/util"
"gopkg.in/yaml.v2"

"go.opentelemetry.io/otel/attribute"
api "go.opentelemetry.io/otel/metric"

argo "github.com/argoproj/argo-rollouts/pkg/apis/rollouts/v1alpha1"
model "github.com/istio-ecosystem/admiral/admiral/pkg/apis/admiral/model"
v1 "github.com/istio-ecosystem/admiral/admiral/pkg/apis/admiral/v1alpha1"
Expand Down Expand Up @@ -101,10 +98,10 @@ func modifyServiceEntryForNewServiceOrPod(
defer util.LogElapsedTimeForTask(ctxLogger, "event", "", "", "", "TotalModifySETime")()
var modifySEerr error
var isServiceEntryModifyCalledForSourceCluster bool
totalConfigWriterEvents.Increment(api.WithAttributes(
attribute.Key("identity").String(sourceIdentity),
attribute.Key("environment").String(env),
))
//totalConfigWriterEvents.Increment(api.WithAttributes(
// attribute.Key("identity").String(sourceIdentity),
// attribute.Key("environment").String(env),
//))
// Assigns sourceIdentity, which could have the partition prefix or might not, to the partitionedIdentity
// Then, gets the non-partitioned identity and assigns it to sourceIdentity. sourceIdentity will always have the original/non-partitioned identity
partitionedIdentity := sourceIdentity
Expand Down

0 comments on commit 5964a96

Please sign in to comment.