Skip to content

Commit

Permalink
Adding replica count check
Browse files Browse the repository at this point in the history
Signed-off-by: kpharasi <[email protected]>
  • Loading branch information
kpharasi committed Dec 10, 2024
1 parent 47c8619 commit 79987d8
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 25 deletions.
3 changes: 0 additions & 3 deletions admiral/pkg/controller/admiral/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,10 @@ func (p *JobController) DoesGenerationMatch(ctxLogger *log.Entry, obj interface{
return false, nil
}

<<<<<<< HEAD
=======
func (p *JobController) IsOnlyReplicaCountChanged(*log.Entry, interface{}, interface{}) (bool, error) {
return false, nil
}

>>>>>>> 564f504f (Add replica count check)
func NewJobController(stopCh <-chan struct{}, handler ClientDiscoveryHandler, config *rest.Config, resyncPeriod time.Duration, clientLoader loader.ClientLoader) (*JobController, error) {

jobController := JobController{}
Expand Down
3 changes: 0 additions & 3 deletions admiral/pkg/controller/admiral/monovertex.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,10 @@ func (p *MonoVertexController) DoesGenerationMatch(ctxLogger *log.Entry, obj int
return false, nil
}

<<<<<<< HEAD
=======
func (p *MonoVertexController) IsOnlyReplicaCountChanged(*log.Entry, interface{}, interface{}) (bool, error) {
return false, nil
}

>>>>>>> 564f504f (Add replica count check)
func NewMonoVertexController(stopCh <-chan struct{}, handler ClientDiscoveryHandler, config *rest.Config, resyncPeriod time.Duration, clientLoader loader.ClientLoader) (*MonoVertexController, error) {

monoVertexController := MonoVertexController{}
Expand Down
3 changes: 0 additions & 3 deletions admiral/pkg/controller/admiral/vertex.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,10 @@ func (p *VertexController) DoesGenerationMatch(ctxLogger *log.Entry, obj interfa
return false, nil
}

<<<<<<< HEAD
=======
func (p *VertexController) IsOnlyReplicaCountChanged(*log.Entry, interface{}, interface{}) (bool, error) {
return false, nil
}

>>>>>>> 564f504f (Add replica count check)
func NewVertexController(stopCh <-chan struct{}, handler ClientDiscoveryHandler, config *rest.Config, resyncPeriod time.Duration, clientLoader loader.ClientLoader) (*VertexController, error) {

vertexController := VertexController{}
Expand Down
9 changes: 0 additions & 9 deletions admiral/pkg/controller/common/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -473,27 +473,18 @@ func DoGenerationCheck() bool {
return wrapper.params.EnableGenerationCheck
}

<<<<<<< HEAD
=======
<<<<<<< HEAD
=======
func IsOnlyReplicaCountChanged() bool {
wrapper.RLock()
defer wrapper.RUnlock()
return wrapper.params.EnableIsOnlyReplicaCountChangedCheck
}

>>>>>>> 564f504f (Add replica count check)
func PreventSplitBrain() bool {
wrapper.RLock()
defer wrapper.RUnlock()
return wrapper.params.PreventSplitBrain
}

<<<<<<< HEAD
=======
>>>>>>> 870eb6da (Add replica count check)
>>>>>>> 564f504f (Add replica count check)
func GetResyncIntervals() util.ResyncIntervals {
wrapper.RLock()
defer wrapper.RUnlock()
Expand Down
7 changes: 0 additions & 7 deletions admiral/pkg/controller/common/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,8 @@ type AdmiralParams struct {
EnableSyncIstioResourcesToSourceClusters bool
DefaultWarmupDurationSecs int64
EnableGenerationCheck bool
<<<<<<< HEAD
PreventSplitBrain bool
=======
<<<<<<< HEAD
=======
EnableIsOnlyReplicaCountChangedCheck bool
PreventSplitBrain bool
>>>>>>> 870eb6da (Add replica count check)
>>>>>>> 564f504f (Add replica count check)

// Cartographer specific params
TrafficConfigPersona bool
Expand Down

0 comments on commit 79987d8

Please sign in to comment.