MESH-5878: Admiral does not create envoy filter on client onboardings #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 76.76% 77.18% +0.41%
==========================================
Files 75 75
Lines 10300 10397 +97
==========================================
+ Hits 7907 8025 +118
+ Misses 1988 1963 -25
- Partials 405 409 +4 ☔ View full report in Codecov by Sentry. |
adilfulara
force-pushed
the
MESH-5878
branch
5 times, most recently
from
d2ffc07 to
d2b5b9b
Compare
vinay-g
reviewed
Jan 3, 2025
vinay-g
approved these changes
Jan 4, 2025
added 14 commits
January 7, 2025 21:33
- Introduce RoutingPolicyProcessor interface - Inject RoutingPolicyService into DependencyHandler Signed-off-by: Adil Fulara <[email protected]>
- Add telemetry logs for RoutingPolicyService methods Signed-off-by: Adil Fulara <[email protected]>
- Move around api in dependency_handler Signed-off-by: Adil Fulara <[email protected]>
- Switch to context logger and add additional logging Signed-off-by: Adil Fulara <[email protected]>
- Refine Signed-off-by: Adil Fulara <[email protected]>
- Refine Signed-off-by: Adil Fulara <[email protected]>
- Revert back to processing dependecy for routing policy after modifySE - Add more logging Signed-off-by: Adil Fulara <[email protected]>
- Process dependency for routing policy before adding to cache Signed-off-by: Adil Fulara <[email protected]>
- Move cache put to start of function to always reflect the real cluster state in cache Signed-off-by: Adil Fulara <[email protected]>
- Move cache put to Controller Signed-off-by: Adil Fulara <[email protected]>
- Add more tests Signed-off-by: Adil Fulara <[email protected]>
- Disable dependency processing during warmup Signed-off-by: Adil Fulara <[email protected]>
Signed-off-by: Adil Fulara <[email protected]>
- Fix test Signed-off-by: Adil Fulara <[email protected]>
- Delete flaky test Signed-off-by: Adil Fulara <[email protected]>
shriramsharma
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Description
What does this change do and why?
Thank you!