State Syncer: add ability to call registry #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Tay <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 77.17% 76.96% -0.21%
==========================================
Files 75 75
Lines 10593 10716 +123
==========================================
+ Hits 8175 8248 +73
- Misses 1995 2041 +46
- Partials 423 427 +4 ☔ View full report in Codecov by Sentry. |
Punakshi
reviewed
Feb 10, 2025
Punakshi
reviewed
Feb 10, 2025
admiral/cmd/admiral/cmd/root.go
Outdated
| @@ -268,11 +274,6 @@ func GetRootCmd(args []string) *cobra.Command { | |||
| rootCmd.PersistentFlags().StringSliceVar(¶ms.IngressVSExportToNamespaces, "ingress_vs_export_to_namespaces", []string{"istio-system"}, "List of namespaces where the ingress VS should be exported") | |||
| rootCmd.PersistentFlags().StringVar(¶ms.IngressLBPolicy, "ingress_lb_policy", "round_robin", "loadbalancer policy for ingress destination rule (round_robin/random/passthrough/least_request)") | |||
|
|
|||
| // Flags pertaining to VS based routing in-cluster | |||
There was a problem hiding this comment.
Will add this back, they weren't in the inner source repo
Signed-off-by: Ryan Tay <[email protected]>
Punakshi
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates registry API into registry client.