[gyim1345] 그래프 구현 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add edge add vertex remove vertex remove edge has vertex has edge
Woomin-Jeon
approved these changes
Jan 10, 2021
Comment on lines
+35
to
+37
| const filteredKeys = [...this.map.get(key).filter(x=> x !== value)]; | ||
|
|
||
| if(!filteredKeys[0]) { |
There was a problem hiding this comment.
filter 대신 find를 쓰면 조금 더 명시적일 것 같습니다!
There was a problem hiding this comment.
filter 하나로 퉁 칠려고 했는데 명시적으로 쓰기 위해서 find 와 filter 둘다 쓰는게 좋을까요?
Comment on lines
+65
to
+66
| const arr = this.map.get(a); | ||
| if(arr) { |
There was a problem hiding this comment.
if (this.map.has(a)) { ... }요렇게 퉁쳐도 될 것 같네여!
There was a problem hiding this comment.
👍
아 이 부분 사실 바로 밑줄에 this.map.get(a) 를 한번 더 써서 변수에 담아서 쓸려고 했는데 정작 변수에 담아 놓고 안썼네요 ㅋㅋ...
한번 더 쓰게 되면 변수에 담아서 쓰는게 좋겠죠?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현한 메서드