callbacks: wrap non-dvc callbacks passed via fsspec #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
force-pushed
the
callbacks-fsspec
branch
from
6bf2d72 to
08a930b
Compare
skshetry
reviewed
Nov 7, 2023
src/dvc_objects/fs/callbacks.py
Outdated
| return maybe_callback | ||
| if isinstance(maybe_callback, Callback): | ||
| return maybe_callback | ||
| return _FsspecCallbackWrapper(maybe_callback) | ||
|
|
||
| @classmethod | ||
| def as_tqdm_callback( |
There was a problem hiding this comment.
Should we move as_tqdm_callback and as_callback to the mixin as well?
There was a problem hiding this comment.
We could move as_tqdm_callback, but I think as_callback should stay here to override the default fsspec implementation
|
Sorry for the delay. The code changes look good to me. Alternatively, we could also try wrapping in between |
pmrowla
force-pushed
the
callbacks-fsspec
branch
from
08a930b to
55abea5
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes iterative/dvc#9984