Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Skip checking localhost links #216

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Skip checking localhost links #216

merged 1 commit into from
Nov 7, 2022

Conversation

aguschin
Copy link
Contributor

@aguschin aguschin commented Nov 7, 2022

Update excluded-links.yml
#188 (comment)

Trying to skip checks for any links to something on the localhost. Checks for them will always fail.

@aguschin aguschin requested a review from yathomasi November 7, 2022 11:26
@aguschin aguschin self-assigned this Nov 7, 2022
@shcheklein shcheklein temporarily deployed to mlem-ai-aguschin-patch--rwrkct November 7, 2022 11:26 Inactive
@aguschin aguschin mentioned this pull request Nov 7, 2022
16 tasks
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

30db37c

Link Check Report

There were no links to check!

Copy link
Contributor

@yathomasi yathomasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aguschin aguschin merged commit 30db37c into main Nov 7, 2022
@aguschin aguschin deleted the aguschin-patch-1 branch November 7, 2022 15:25
@jorgeorpinel
Copy link
Contributor

Nice. TBH I think we should just not make actual links to localhost. Why not let those be simple quote/code blocks for the user to copy/paste?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants