Update theme to 0.2.x #249
Conversation
Link Check ReportThere were no links to check! |
There was a problem hiding this comment.
Nice work! I noticed some things while going through each page type that'll need to be changed, but this is most of the way there. Any subjective quibbles I have with implementation I didn't bother to list and can be handled later.
Homepage:
-
Mobile and tablet look identical! 🎉
-
Large padding added to logos on desktop screen
vs
Docs:
-
Extra padding in docs sidebars
-
Sticky sidebars broken when scrolled
-
Command anchors could use
scroll-padding
There was a problem hiding this comment.
Thanks, @rogermparent for the review and help with this PR. I have covered all from the review list. PTAL
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| yarn lint-staged |
There was a problem hiding this comment.
Just noticed the husky pre-commit was not working. It was simple change to add to this PR
| [class^='styles-module--innerSidebar'] { | ||
| @apply pt-20; | ||
| } |
There was a problem hiding this comment.
This one could be the kinda hacky way but I didn't want to shadow the entire CSS file for a single change.
|
|
Thanks for pointing these out. The top bar was updated to use the same approach used by the theme. The default height in the theme is smaller. I did add the margin but for sure we can fine-tune it more.
Looks like I overlooked the middle screen sizes. I will make sure of them. Thanks. |
Ah yeah, the new version of the theme has the children of the layout provide their own padding, particularly to get the docs sidebars working because they specifically don't want any top margin. On the same topic, looks like 404 needs some top margin. |
Great! Thanks again for the help and review throughout this PR. |
Similar to iterative/dvc.org#4118, iterative/cml.dev#402 for
mlem.ai.