Create docker-image.yml #561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Its4Nik we really appreciate your effort on this one. It would be great if you could upgrade your PR a bit considering my comment above. Thanks! |
I am unsure which comment you are referring to, I can't seem to find it... |
electronick
requested changes
Oct 29, 2024
.github/workflows/docker-image.yml
Outdated
| - uses: actions/checkout@v2 | ||
| name: Checkout repository | ||
|
|
||
| - uses: pmorelli92/[email protected] |
There was a problem hiding this comment.
Looks like this repo is out of date and the owner strongly advices to use docker/build-push-action instead.
There was a problem hiding this comment.
Im gonna adjust it accordingly
|
@electronick Please take another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows automatic image building using a GitHub Workflow.
The built image will be available under the GitHub container registry (ghcr.io)
The image gets built when a new release is published, we could change the behavior to have Development images as well and/or always build an image when we push to the main branch.