Make Invidious compliant to Crystal 1.15 formatting rules #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
force-pushed
the
crystal-nightly-formatter-changes
branch
2 times, most recently
from
c93a202 to
70243c8
Compare
|
Save for the changes in |
syeopite
force-pushed
the
crystal-nightly-formatter-changes
branch
from
70243c8 to
0cce233
Compare
syeopite
force-pushed
the
crystal-nightly-formatter-changes
branch
from
0cce233 to
e71bcc8
Compare
|
Blocked until the release of Crystal 1.14.1 |
|
1.14.1 just got released but there's not really much of a point to updating when 1.15 will release tomorrow on the 9th. |
syeopite
force-pushed
the
crystal-nightly-formatter-changes
branch
from
e71bcc8 to
e137870
Compare
syeopite
changed the title
Ameba could be built with an older version of Crystal that follows a different set of formatting rules than the latest version causing the Lint/Formatting rule to fail when in actuality the code is actually compliant with the formatting rules in the latest version of Crystal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI on nightly.
Crystal Nightly recently enabled a bunch of new formatting rules that will be introduced in the upcoming Crystal 1.15 release.
These changes are backwards compatible and as such the CI should pass on older Crystal versions.
crystal-lang/crystal#14718