Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Content-Type from the headers of the reqwest builders. #14

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Remove the Content-Type from the headers of the reqwest builders. #14

merged 1 commit into from
Aug 21, 2024

Conversation

francois-caddet
Copy link
Contributor

@francois-caddet francois-caddet commented Aug 17, 2024 •
edited
Loading

Description

fix #13

A strange API error with code 400 not documented in the mistral.ai documentation.

Checklist

  • I removed the header Content-Type from the reqwest builders (Client::build_request, Client::build_request_async, Client::build_request_stream). They apparently are conflicting with reqwest internal stufs.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 17, 2024 •
edited
Loading

Walkthrough

The recent changes in the Client implementation streamline the HTTP request header setup by removing the Content-Type: application/json header from multiple instances. This adjustment simplifies the request-building process and enhances compatibility with various API endpoints, allowing for a more flexible handling of content types without enforcing a specific format.

Changes

Files Change Summary
src/v1/client.rs Removed Content-Type: application/json header in multiple request configurations.

Assessment against linked issues

Objective Addressed Explanation
API Error 400 - Bad Request: Diagnose potential issues causing the 400 Bad Request error (#[13]) ❓ It is unclear if the removal of the header relates to the error. Further investigation is needed.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@francois-caddet
fix(Client): Remove the Content-Type from the headers of the reqwes…
e987b5d 
…t builders.

They apparently are conflicting with reqwest internal stufs.

fix ivangabriele#13
@ivangabriele ivangabriele merged commit 9bfbf2e into ivangabriele:main Aug 21, 2024
2 checks passed
@ivangabriele ivangabriele added the bug Something isn't working label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Error 400 - Bad Request
2 participants
@francois-caddet @ivangabriele