Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache improvement #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vortigont
Copy link

  • cached node link updates on add/remove also
  • ListNode has a constructor now, simplifies code, ensures *next is a nullptr if unlinked
  • some code sanity checks and cleanup
  • add head()/tail()/exist() helpers to make user code simple on Node access/checks
  • unit tests updated for new helpers

 - cached node link updates on add/remove also
 - ListNode has a constructor now, simplifies code, ensures *next is a nullptr if unlinked
 - some code sanity checks and cleanup
 - add head()/tail()/exist() helpers to make user code simple on Node access/checks
 - unit tests updated for new helpers

Signed-off-by: Emil Muratov <[email protected]>
@ivanseidel
Copy link
Owner

Really interesting. Its missing a few docs for people to know how to use the new methods. Also, have you tested on arduino platform? is it compliant?

@vortigont
Copy link
Author

for sure it works pretty fine with Arduino. Overloaded constructors mostly used internally to optimize node adding/creating, not much of a use for user actually, unless you want to create a list of lists :))
The other methods like head()/tail() are pretty obvious, but could be mentioned in examples also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants