Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade LLVM Version #46

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Upgrade LLVM Version #46

merged 1 commit into from
Feb 7, 2025

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Feb 4, 2025

Addresses #45

This PR introduces changes that were required to run tutorials on MacOS 12.7.6 with latest LLVM build (as of 2025-01-22).

@j2kun
Copy link
Owner

j2kun commented Feb 5, 2025

Can you also bump the commit referenced by bazel here:

LLVM_COMMIT = "29b92d07746fac26cd64c914bc9c5c3833974f6d"
?

@mtsokol
Copy link
Contributor Author

mtsokol commented Feb 5, 2025

Ah right, I missed bazel build. Done!

@mtsokol mtsokol force-pushed the bump-llvm-version branch 2 times, most recently from 19c87ea to 8cd4bb9 Compare February 5, 2025 23:53
@mtsokol
Copy link
Contributor Author

mtsokol commented Feb 5, 2025

Ok, now it should be ready, can you retrigger CI?

@j2kun
Copy link
Owner

j2kun commented Feb 6, 2025

I'm guessing you may need to substitute some of the references to mlir-cpu-runner in

rg mlir-cpu-runner tests
tests/BUILD
16:        "@llvm-project//mlir:mlir-cpu-runner",

tests/lit.cmake.cfg.py
49:    "mlir-cpu-runner",

tests/CMakeLists.txt
11:    mlir-cpu-runner

tests/ctlz_runner.mlir
8:// RUN: | mlir-cpu-runner -e test_7i32_to_29 -entry-point-result=i32 > %t
26:// RUN: | mlir-cpu-runner -e test_7i64_to_61 -entry-point-result=i64 > %t

Probably sed -i 's/mlir-cpu-runner/mlir-runner/g' tests/**/* would suffice.

@mtsokol
Copy link
Contributor Author

mtsokol commented Feb 7, 2025

All green now!

@j2kun j2kun merged commit 5f38e79 into j2kun:main Feb 7, 2025
2 checks passed
@mtsokol mtsokol deleted the bump-llvm-version branch February 7, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants