Updates, features, and refactoring for Modular PBR Shaders #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to store tbnMat as a publicly accessible variable in the PBRSurface.glsl struct, that way tbnMat won't need recalculated anywhere else in the shader it is needed.
caused a crash trying to assign a non existent variable. but it isn't needed anymore anyways since surface.geometryNormal already is set to = norm by default now
…2298 update LWJGL3 to v3.3.4
…-patch-3 Add tbnMat variable to PBRSurface.glsl
[ Fix ] Minor refactoring to DisplayInfo.class jMonkeyEngine#2345
|
Not sure what I did with the fork I used for this PR, but it seemed to randomly include some other commits from months ago... Usually I do my PRs by editing files in JME's repo 1 at a time and let it auto-generate a new branch for my changes prior to merging, but this time I decided to try forking master first, making my changes there, and then submitting a PR from that branch. IDK if I messed something up, but its late now so I might just remake this PR when I have time tomorrow. |
|
somehow the target branch got messed up in this pr... i redid the same thing in a new pr and it worked, idk if github bugged out on me or if I made a mistake. Either way, disregard this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big PR that makes many minor changes to the new modular PBR system so it can work with PBRTerrains and any other potential forks.
Since no bugs were reported in the last alpha version, I've now replaced the main PBRLighting.j3md shader with this new modular version.
I'm still adding some small things to this PR, and still need to upload the new modular PBR terrain files, so there will probably be more changes to this PR soon, but feel free to review in the meantime.
I also plan to make another PR with some more minor improvements to further modularize the PBRSurface struct (and add some other similar structs) later on in 3.8 beta after collecting more feedback, so I'll be merging this PR very soon, likely before it gets full review. But I will ensure all feedback regarding the new Modular shader system will be addressed before 3.8 reaches stable.