Fix getLabel() return type (#16)

jack-worman · Jul 7, 2023 · 9ff20ae · 9ff20ae
1 parent 3f9b225
commit 9ff20ae
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/packages/zend-dojo/library/Zend/Dojo/Form/Element/Button.php b/packages/zend-dojo/library/Zend/Dojo/Form/Element/Button.php
@@ -62,10 +62,8 @@ public function __construct($spec, $options = null)
      * If no label is present, returns the currently set name.
      *
      * If a translator is present, returns the translated label.
-     *
-     * @return string
      */
-    public function getLabel()
+    public function getLabel(): string|null
     {
         $value = parent::getLabel();
 

diff --git a/packages/zend-form/library/Zend/Form/Element.php b/packages/zend-form/library/Zend/Form/Element.php
@@ -636,12 +636,7 @@ public function setLabel($label)
         return $this;
     }
 
-    /**
-     * Retrieve element label
-     *
-     * @return string
-     */
-    public function getLabel()
+    public function getLabel(): string|null
     {
         $translator = $this->getTranslator();
         if (null !== $translator) {

diff --git a/packages/zend-form/library/Zend/Form/Element/Hash.php b/packages/zend-form/library/Zend/Form/Element/Hash.php
@@ -208,10 +208,8 @@ public function getTimeout()
 
     /**
      * Override getLabel() to always be empty
-     *
-     * @return null
      */
-    public function getLabel()
+    public function getLabel(): string|null
     {
         return null;
     }
@@ -251,7 +249,7 @@ public function render(Zend_View_Interface $view = null)
      */
     protected function _generateHash()
     {
-        $this->_hash = md5((string) 
+        $this->_hash = md5((string)
             Zend_Crypt_Math::randBytes(32)
         );
         $this->setValue($this->_hash);

diff --git a/packages/zend-form/library/Zend/Form/Element/Submit.php b/packages/zend-form/library/Zend/Form/Element/Submit.php
@@ -66,10 +66,8 @@ public function __construct($spec, $options = null)
      * If no label is present, returns the currently set name.
      *
      * If a translator is present, returns the translated label.
-     *
-     * @return string
      */
-    public function getLabel()
+    public function getLabel(): string|null
     {
         $value = parent::getLabel();