Merge pull request #45 from jackh726/bigtools_refactor_rebase2

Refactor bigtools internals and API for writing
jackh726 · Jul 5, 2024 · f49b0c9 · f49b0c9
2 parents 3598601 + e446a6e
commit f49b0c9
Show file tree

Hide file tree

Showing 29 changed files with 2,118 additions and 2,274 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/bigtools/Cargo.toml b/bigtools/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "bigtools"
-version = "0.4.4-dev"
+version = "0.5.0-dev"
 authors = ["Jack Huey <[email protected]>"]
 edition = "2021"
 license = "MIT"

diff --git a/bigtools/src/bbi.rs b/bigtools/src/bbi.rs
@@ -3,7 +3,7 @@ pub(crate) mod bbiread;
 #[cfg(feature = "write")]
 pub(crate) mod bbiwrite;
 #[cfg(feature = "write")]
-pub mod bedchromdata;
+pub mod beddata;
 #[cfg(feature = "read")]
 pub(crate) mod bigbedread;
 #[cfg(feature = "write")]

diff --git a/bigtools/src/bbi/bbiread.rs b/bigtools/src/bbi/bbiread.rs
@@ -501,8 +501,8 @@ impl GenericBBIRead<ReopenableFile> {
     /// Opens a generic bbi file
     pub fn open_file(path: &str) -> Result<Self, GenericBBIFileOpenError> {
         let reopen = ReopenableFile {
-            path: path.to_string(),
-            file: File::open(path)?,
+            file: File::open(&path)?,
+            path: path.into(),
         };
         let b = GenericBBIRead::open(reopen);
         if b.is_err() {