Fix behaviour of names argument in bigWigAverageOverBed of pybigtools. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! If you can fix formatting, I can merge. Otherwise, I'll fix this weekend. |
Fix behaviour of names argument in bigWigAverageOverBed of pybigtools
for `True` and `1+` as values passed to `Name::Column()` were off by one.
Before for a 4 column BED file, you would get the following error
for `True` or `4`:
Exception: Invalid name column option. Number of columns (4) is less than the value specified (5).
ghuls
force-pushed
the
fix_names_argument_in_pybigtools
branch
from
e70277d to
49cea3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix behaviour of names argument in bigWigAverageOverBed of pybigtools for
Trueand1+as values passed toName::Column()were off by one.Before for a 4 column BED file, you would get the following error for
Trueor4: