Fix "DeniedRequiresTLS" value for activation request #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add the correct 0x6 and update the comment to say "table 49" instead of 48? I'm not sure where the mistake came in. The AutoSAR spec seems to have only referenced a few of them so I imagine copy/paste error from one of the other sources. 6 should be DeniedUnsupportedActivationType |
The value corresponding to a Negative Response "Requires TLS" after sending a Routing Activation Request is invalid. Currently this value is set to "0x06", but according to the ISO-13400 standard, the "0x06" value corresponds to an unknown activation type. Referring to the standard, we can state that the Negative Response Code "Requires TLS" should be set to "0x07" : > After reception of a routing activation request message with a routing activation type, which requires the > secure TLS connection to the DoIP entity then each DoIP entity supporting the secure TCP communication > shall send the routing activation response message with the response code set to 0x07. This patch applies the correct correction to the "DeniedRequiresTLS" value.
clementramirez
force-pushed
the
main
branch
from
135d52f to
daebe73
Compare
|
Thanks for your fast reply, The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The value corresponding to a Negative Response "Requires TLS" after sending a Routing Activation Request is invalid.
Currently this value is set to "0x06", but according to the ISO-13400 standard, the "0x06" value corresponds to an unknown activation type.
Referring to the standard, we can state that the Negative Response Code "Requires TLS" should be set to "0x07" :
This patch applies the correct correction to the "DeniedRequiresTLS" value.
Sincerely,
Clément Ramirez