Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added py.typed and setup.py support #55

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

cstaylor
Copy link
Contributor

I was getting errors from mypy when trying to use doipclient, and found the project is missing a py.typed file as described here.

@jacobschaer
Copy link
Owner

Seems reasonable to me. Thanks - I don't think the code is super diligent about type annotations, so if there's any deficiencies you come across with those, feel free to MR as well and I'll get them in.

@jacobschaer jacobschaer merged commit ff53797 into jacobschaer:main Nov 12, 2024
17 checks passed
@jacobschaer
Copy link
Owner

I had to change setup.py to publish - copied some other examples.

@cstaylor cstaylor deleted the feature/pytyped branch November 12, 2024 14:59
@cstaylor
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants