Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room game functionalities #31

Merged
merged 53 commits into from
Dec 1, 2024
Merged

Room game functionalities #31

merged 53 commits into from
Dec 1, 2024

Conversation

AnoldGH
Copy link
Collaborator

@AnoldGH AnoldGH commented Nov 30, 2024

Components & utilities necessary to hold room games

As of now, we have functionalities to

Part of both #4 and #5

@AnoldGH AnoldGH mentioned this pull request Nov 30, 2024
6 tasks
@AnoldGH AnoldGH marked this pull request as ready for review November 30, 2024 04:25
@AnoldGH AnoldGH requested review from Hakob3215 and jaden-yejun-lee and removed request for Hakob3215 November 30, 2024 05:50
Copy link
Collaborator

@Hakob3215 Hakob3215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in room.js, I feel as though you should remove the test function call

@AnoldGH
Copy link
Collaborator Author

AnoldGH commented Nov 30, 2024

in room.js, I feel as though you should remove the test function call

Good catch, will piggyback it in the next commit

@AnoldGH
Copy link
Collaborator Author

AnoldGH commented Nov 30, 2024

in room.js, I feel as though you should remove the test function call

test() is now commented out with the new commit

Copy link
Collaborator

@Hakob3215 Hakob3215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, nice changes

Copy link
Collaborator

@MichaelPeng123 MichaelPeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnoldGH AnoldGH merged commit 042764c into jaden-yejun-lee:main Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants