Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#211] Error page #212

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[#211] Error page #212

merged 2 commits into from
Dec 10, 2024

Conversation

YunSukHyun
Copy link
Collaborator

pr 제목 예시

[#211] 한 일 간략히 설명

📝 주요 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

에러 페이지 제작

📷 스크린샷 (선택)

image

💬 고민 중인 부분 및 참고사항 (선택)

close #211

@YunSukHyun YunSukHyun added the Feat 기능 추가 label Oct 5, 2024
@YunSukHyun YunSukHyun requested a review from kimyou1102 October 5, 2024 11:18
@YunSukHyun YunSukHyun self-assigned this Oct 5, 2024
Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
loco-moco-ogri ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 0:58am

Copy link
Collaborator

@kimyou1102 kimyou1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!

src={'/error.png'}
height={80}
width={80}
alt="bad"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error page image 같은 명확한 이름으로 하면 스크린리더기를 사용하는 사용자에게 도움이 될거 같아요!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 반영하겠씁니다

@YunSukHyun YunSukHyun merged commit b678037 into main Dec 10, 2024
4 checks passed
@YunSukHyun YunSukHyun deleted the feat/#211/errorPage branch December 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error page 제작
2 participants