Grammar fix #1055
Open
Grammar fix #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if I missed a spot. |
|
While this does resolve some grammar issues, I think that everything in this PR will end up getting overwritten when we add localization, which will utilize resource bundles and do plurals like this: https://docs.oracle.com/javase/tutorial/i18n/format/choiceFormat.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request...
Description
In this PR I have made very minor changes, improving the overall grammar of the bot's responses.
Here are a few examples, version 0.3.6 being on top and this PR's below.
1 entries→1 entry1 items→1 item1 entries→1 entryPurpose
Saying
1 entryinstead of1 entriesjust makes more sense. (grammar duh)Anything else than
1 entrylike2 entrieswill of course remain as2 entries.This seemed like a small thing I thought I would be able to fix.