Fix documentation about NoSQL database behavior. #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
…behavior on NoSQL Signed-off-by: Otavio Santana <[email protected]>
gavinking
reviewed
Feb 6, 2025
| @@ -146,17 +146,33 @@ default Stream<T> stream() { | |||
| * Returns the total number of elements across all pages of query results, if the | |||
| * {@link #pageRequest()} specified that {@linkplain PageRequest#requestTotal the | |||
| * total should be retrieved from the database}. | |||
| * | |||
| * <p><strong>Note for NoSQL databases:</strong> Not all NoSQL databases support counting the total | |||
There was a problem hiding this comment.
Can we perhaps use @apiNote for this?
njr-11
reviewed
Feb 6, 2025
njr-11
reviewed
Feb 6, 2025
|
@njr-11 Thanks for the notes; I have a different way to see the reuse of exceptions. Could you check it and let me know your thoughts? |
njr-11
requested changes
Feb 11, 2025
There was a problem hiding this comment.
See review comments. There is no good solution for NoSQL, so I'll mostly agree to the behavior that Otavio wants, but I still see this as a more undesirable way for a provider to handle things, so I don't want to see significant portions of the JavaDoc for these methods being cluttered up with it and distracting from more core usage.
Co-authored-by: Nathan Rauh <[email protected]>
Co-authored-by: Nathan Rauh <[email protected]>
Co-authored-by: Nathan Rauh <[email protected]>
Co-authored-by: Nathan Rauh <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
njr-11
reviewed
Feb 11, 2025
Co-authored-by: Nathan Rauh <[email protected]>
njr-11
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes: NoSQL databases need to be allowed to raise errors for function that the database type is not capable o
Changes
Fixes: