Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated OSGi data #202

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Updated OSGi data #202

merged 1 commit into from
Feb 7, 2022

Conversation

tomjenkinson
Copy link
Contributor

Signed-off-by: Tom Jenkinson [email protected]

@tomjenkinson tomjenkinson force-pushed the osgi-metadata branch 2 times, most recently from 44064b8 to 18c2de9 Compare February 3, 2022 18:24
starksm64
starksm64 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@starksm64 starksm64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes that I just tested out, so looks good

@tomjenkinson
Copy link
Contributor Author

The CI run failed, it looks like Jenkins or something. I will re-run it

@tomjenkinson
Copy link
Contributor Author

retest this please

1 similar comment
@tomjenkinson
Copy link
Contributor Author

retest this please

@tomjenkinson
Copy link
Contributor Author

Something is up with the glassfish build: https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-publish-to-eclipse-download/627/ - the previous build of the same SHA passed: https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-publish-to-eclipse-download/626/

@starksm64
Copy link
Contributor

The TCK run is failing because of a new dependency on a snapshot release of org.glassfish.web:tagsdoc:

[INFO] [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java (generateTldDoc) on project jakarta.servlet.jsp.jstl: Execution generateTldDoc of goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java failed: Plugin org.codehaus.mojo:exec-maven-plugin:3.0.0 or one of its dependencies could not be resolved: Failed to collect dependencies at org.codehaus.mojo:exec-maven-plugin:jar:3.0.0 -> org.glassfish.web:tagsdoc:jar:1.0-SNAPSHOT: Failed to read artifact descriptor for org.glassfish.web:tagsdoc:jar:1.0-SNAPSHOT: Could not transfer artifact org.glassfish.web:tagsdoc:pom:1.0-SNAPSHOT from/to maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: [ossrh-snapshots (http://oss.sonatype.org/content/repositories/snapshots, default, snapshots)] -> [Help 1]

You will need to add -Psnapshots to the build to allow the snapshots staging repo to be included.

@tomjenkinson
Copy link
Contributor Author

I think I have that:

git clone https://github.com/eclipse-ee4j/glassfish.git
cd glassfish
git checkout master
mvn -Pstaging clean install -D$OVERRIDE_TRANSACTION_API_PROPERTY=$SNAPSHOT_VERSION -DskipTests

(from https://ci.eclipse.org/jta/job/eclipse-ee4j_jta-api-pulls-openjdk-jdk11-latest/configure)

@tomjenkinson
Copy link
Contributor Author

When I looked at the glassfish CI, one of their builds for SHA 3463ea053c958ce4d86dc751837ee025d3c38f0e work and the next for SHA 3463ea053c958ce4d86dc751837ee025d3c38f0e failed.

@starksm64
Copy link
Contributor

That mvn command is just overriding the version of transactions API jar used in the build. You need to enable the snapshots profile in addition to the staging profile:

mvn -Pstaging -Psnapshots clean install -D$OVERRIDE_TRANSACTION_API_PROPERTY=$SNAPSHOT_VERSION -DskipTests

@tomjenkinson
Copy link
Contributor Author

Sorry, I missed it (I presume it was that I was seeing -Pstaging and getting confused)

@tomjenkinson
Copy link
Contributor Author

retest this please

@tomjenkinson
Copy link
Contributor Author

tomjenkinson commented Feb 4, 2022 •
edited
Loading

It's still not working for CI :(

The job config currently says:

git clone https://github.com/eclipse-ee4j/glassfish.git
cd glassfish
git checkout master
mvn -Psnapshots -Pstaging clean install -D$OVERRIDE_TRANSACTION_API_PROPERTY=$SNAPSHOT_VERSION -DskipTests

I will try to run it locally too to see what I get (OVERRIDE_TRANSACTION_API_PROPERTY=jakarta.transaction-api.version and SNAPSHOT_VERSION=2.0.1-SNAPSHOT)

@tomjenkinson
Copy link
Contributor Author

I am getting what seems to be the same outcome locally.

@starksm64
Copy link
Contributor

Curious because it is working for me, and a pull showed no new changes since the job ran:

└> mvn -Psnapshots -Pstaging clean install -Djakarta.transaction-api.version=2.0.1-SNAPSHOT -DskipTests
...
INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for GlassFish Project 7.0.0-SNAPSHOT:
[INFO] 
[INFO] GlassFish Project .................................. SUCCESS [  0.266 s]
[INFO] Code Quality Verification Tools - Configuration .... SUCCESS [  0.241 s]
[INFO] GlassFish Nucleus Parent Project ................... SUCCESS [  2.204 s]
[INFO] GlassFish Nucleus Project .......................... SUCCESS [  0.104 s]
[INFO] GlassFish Snapshots Parent ......................... SUCCESS [  0.103 s]
[INFO] Tags master SNAPSHOT ............................... SUCCESS [ 22.194 s]
[INFO] jBatch master SNAPSHOT ............................. SUCCESS [ 11.511 s]
[INFO] Glassfish Nucleus HK2 Modules ...................... SUCCESS [  0.072 s]
[INFO] Tiger types- type arithmetic library for Java5 ..... SUCCESS [  2.487 s]
[INFO] HK2 configuration module ........................... SUCCESS [  4.786 s]
[INFO] HK2 config types ................................... SUCCESS [  0.815 s]
[INFO] Distribution Fragments for various OSGi platforms .. SUCCESS [  0.068 s]
[INFO] Apache Felix, associated bundles and conf files .... SUCCESS [  0.191 s]
[INFO] Scattered Archive APIs of Glassfish ................ SUCCESS [  0.274 s]
[INFO] GlassFish Nucleus Grizzly modules .................. SUCCESS [  0.066 s]
[INFO] grizzly-config ..................................... SUCCESS [  1.992 s]
[INFO] Nucleus Grizzly jars Combining ..................... SUCCESS [  1.182 s]
[INFO] Public APIs of Glassfish ........................... SUCCESS [  2.213 s]
[INFO] GlassFish Nucleus Common modules ................... SUCCESS [  0.080 s]
[INFO] Common Utilities ................................... SUCCESS [  5.460 s]
[INFO] Simple Public APIs of Glassfish .................... SUCCESS [  0.238 s]
[INFO] GlassFish Nucleus Core modules ..................... SUCCESS [  0.062 s]
[INFO] Appserver Core Bootstraping Classes ................ SUCCESS [  1.017 s]
[INFO] Test Utilities ..................................... SUCCESS [  0.489 s]
[INFO] Admin Modules ...................................... SUCCESS [  0.061 s]
[INFO] admin-config-api ................................... SUCCESS [  5.113 s]
[INFO] Private APIs of Glassfish .......................... SUCCESS [  1.317 s]
[INFO] Nucleus Security Parent ............................ SUCCESS [  0.057 s]
[INFO] GlassFish SSL Implementation Module ................ SUCCESS [  0.468 s]
[INFO] GlassFish Nucleus Deployment Related Modules ....... SUCCESS [  0.054 s]
[INFO] Deployment Related Common Classes .................. SUCCESS [  1.929 s]
[INFO] Security Core Classes .............................. SUCCESS [  2.588 s]
[INFO] Security Services and SPI .......................... SUCCESS [  1.899 s]
[INFO] admin-util ......................................... SUCCESS [  2.650 s]
[INFO] Admin CLI bridge command to the OSGi Shell ......... SUCCESS [  0.508 s]
[INFO] Cluster ............................................ SUCCESS [  0.055 s]
[INFO] cluster-common ..................................... SUCCESS [  0.714 s]
[INFO] Cluster SSH Provisioning ........................... SUCCESS [  0.581 s]
[INFO] Nucleus Logging Classes ............................ SUCCESS [  1.839 s]
[INFO] admin-launcher ..................................... SUCCESS [  1.033 s]
[INFO] admin-cli .......................................... SUCCESS [  1.574 s]
[INFO] Admin CLI, interactive OSGi shell command .......... SUCCESS [  0.680 s]
[INFO] OSGi Container ..................................... SUCCESS [  0.490 s]
[INFO] GlassFish API Exporter Module ...................... SUCCESS [  0.164 s]
[INFO] flashlight-framework ............................... SUCCESS [  1.252 s]
[INFO] Kernel Classes ..................................... SUCCESS [  4.639 s]
[INFO] GMS Bootstrap Module ............................... SUCCESS [  0.451 s]
[INFO] cluster-admin ...................................... SUCCESS [  1.416 s]
[INFO] admin-server-management ............................ SUCCESS [  3.825 s]
[INFO] cluster-cli ........................................ SUCCESS [  1.400 s]
[INFO] GMS Module ......................................... SUCCESS [  0.815 s]
[INFO] Glassfish MBeanServer support ...................... SUCCESS [  0.746 s]
[INFO] AMX Core ........................................... SUCCESS [  3.540 s]
[INFO] GlassFish Extra JRE Packages ....................... SUCCESS [  0.094 s]
[INFO] Context Propagation ................................ SUCCESS [  3.313 s]
[INFO] admin-monitoring ................................... SUCCESS [  1.168 s]
[INFO] GlassFish Admin REST Parent ........................ SUCCESS [  0.056 s]
[INFO] GlassFish Admin REST Testing Framework ............. SUCCESS [  0.288 s]
[INFO] GlassFish Admin REST Client ........................ SUCCESS [  0.548 s]
[INFO] Eclipse GlassFish Parent Project ................... SUCCESS [  0.053 s]
[INFO] GlassFish EJB container related modules ............ SUCCESS [  0.054 s]
[INFO] GlassFish Core EJB Client .......................... SUCCESS [  0.609 s]
[INFO] GlassFish Common modules ........................... SUCCESS [  0.054 s]
[INFO] Java EE dependent public APIs of Glassfish ......... SUCCESS [  0.380 s]
[INFO] GlassFish Java EE Annotation Framework ............. SUCCESS [  0.785 s]
[INFO] nucleus.resources .................................. SUCCESS [  0.718 s]
[INFO] GlassFish Deployment Related Modules ............... SUCCESS [  0.053 s]
[INFO] Deployment Object Library .......................... SUCCESS [  6.292 s]
[INFO] GlassFish Security Parent .......................... SUCCESS [  0.052 s]
[INFO] Jaspic Provider Framework .......................... SUCCESS [  0.620 s]
[INFO] GlassFish Transaction modules ...................... SUCCESS [  0.053 s]
[INFO] Transaction Service Internal API ................... SUCCESS [  0.554 s]
[INFO] GlassFish Resources infrastructure related modules . SUCCESS [  0.052 s]
[INFO] Resources Connector ................................ SUCCESS [  1.797 s]
[INFO] Connectors Parent .................................. SUCCESS [  0.055 s]
[INFO] Connectors Private APIs for GlassFish Containers ... SUCCESS [  1.770 s]
[INFO] EJB container Internal API ......................... SUCCESS [  0.535 s]
[INFO] Java binding for libpam.so ......................... SUCCESS [  0.395 s]
[INFO] Java EE Security Core Classes ...................... SUCCESS [  2.458 s]
[INFO] stats77 ............................................ SUCCESS [  1.019 s]
[INFO] Deployment Related JavaEE Core Classes ............. SUCCESS [  0.680 s]
[INFO] Glassfish Naming ................................... SUCCESS [  1.020 s]
[INFO] Container Common ................................... SUCCESS [  1.527 s]
[INFO] GlassFish persistence related modules .............. SUCCESS [  0.055 s]
[INFO] Common persistence code between JPA and CMP ........ SUCCESS [  0.750 s]
[INFO] EJB Container connector for Glassfish .............. SUCCESS [  0.541 s]
[INFO] GlassFish ORB related modules ...................... SUCCESS [  0.055 s]
[INFO] GlassFish ORB enabler implementation ............... SUCCESS [  0.537 s]
[INFO] GlassFish ORB connector implementation ............. SUCCESS [  1.640 s]
[INFO] GlassFish Core EJB container implementation ........ SUCCESS [  7.452 s]
[INFO] GlassFish Web container related modules ............ SUCCESS [  0.054 s]
[INFO] Jersey EJB Component Provider Module ............... SUCCESS [  1.080 s]
[INFO] Connector for GlassFish Admin REST Service ......... SUCCESS [  0.566 s]
[INFO] GlassFish Admin REST Service ....................... SUCCESS [  5.186 s]
[INFO] Nucleus template ................................... SUCCESS [  0.112 s]
[INFO] flashlight-agent ................................... SUCCESS [  0.089 s]
[INFO] GlassFish Flashlight Extra JDK Pkgs ................ SUCCESS [  0.065 s]
[INFO] Flashlight ......................................... SUCCESS [  0.055 s]
[INFO] Deployment Related Admin Classes ................... SUCCESS [  1.544 s]
[INFO] AutoDeploy Classes ................................. SUCCESS [  0.658 s]
[INFO] Set of DTDs for Nucleus distributions .............. SUCCESS [  0.073 s]
[INFO] Set of schemas for Nucleus ......................... SUCCESS [  0.071 s]
[INFO] Nucleus distributions .............................. SUCCESS [  0.056 s]
[INFO] Nucleus distribution Common module ................. SUCCESS [  0.181 s]
[INFO] Admin Console Jackson JAXB Repackaging ............. SUCCESS [  1.931 s]
[INFO] Glassfish featuresets .............................. SUCCESS [  0.054 s]
[INFO] Glassfish Nucleus Atomic Featureset ................ SUCCESS [  0.217 s]
[INFO] Glassfish Atomic Distribution ...................... SUCCESS [ 14.681 s]
[INFO] Glassfish Nucleus Featureset ....................... SUCCESS [  0.067 s]
[INFO] Nucleus Distribution ............................... SUCCESS [ 14.739 s]
[INFO] Diagnostics ........................................ SUCCESS [  0.054 s]
[INFO] Diagnostics API .................................... SUCCESS [  0.285 s]
[INFO] GlassFish Diagnostics Context ...................... SUCCESS [  0.799 s]
[INFO] AMX JavaEE ......................................... SUCCESS [  1.049 s]
[INFO] LDAP Booster Pack .................................. SUCCESS [  0.873 s]
[INFO] GlassFish HA modules ............................... SUCCESS [  0.058 s]
[INFO] GlassFish ha-file-store ............................ SUCCESS [  0.249 s]
[INFO] GlassFish ha-shoal-cache-bootstrap ................. SUCCESS [  0.310 s]
[INFO] GlassFish ha-shoal-store ........................... SUCCESS [  0.579 s]
[INFO] Set of DTDs for GlassFish Java EE distributions .... SUCCESS [  0.163 s]
[INFO] Set of schemas for Jakarta EE ...................... SUCCESS [  0.327 s]
[INFO] Connector for GlassFish Web Container .............. SUCCESS [  0.606 s]
[INFO] GlassFish Connectors Connector ..................... SUCCESS [  0.562 s]
[INFO] App Client Modules ................................. SUCCESS [  0.056 s]
[INFO] GlassFish App Client Server-side Modules ........... SUCCESS [  0.056 s]
[INFO] GlassFish AppClient Server-Side Connector .......... SUCCESS [  0.379 s]
[INFO] Deployment Related JavaEE Full Profile Classes ..... SUCCESS [  0.995 s]
[INFO] Admin Modules ...................................... SUCCESS [  0.056 s]
[INFO] Backup Restore classes ............................. SUCCESS [  0.586 s]
[INFO] App Server CLI Skinning Class ...................... SUCCESS [  0.465 s]
[INFO] admin-cli-optional ................................. SUCCESS [  0.645 s]
[INFO] admin-core ......................................... SUCCESS [  0.856 s]
[INFO] Appserver template ................................. SUCCESS [  0.141 s]
[INFO] GlassFish Core modules ............................. SUCCESS [  0.056 s]
[INFO] Java EE related distributions kernel Classes ....... SUCCESS [  0.524 s]
[INFO] GlassFish API Exporter Module Fragment ............. SUCCESS [  0.070 s]
[INFO] JTA Implementation for Glassfish ................... SUCCESS [  0.949 s]
[INFO] Jakarta Mail Resources Support related modules ..... SUCCESS [  0.055 s]
[INFO] Jakarta Mail Connector ............................. SUCCESS [  1.285 s]
[INFO] Connectors Runtime ................................. SUCCESS [  3.690 s]
[INFO] JTS Implementation for Glassfish ................... SUCCESS [  4.892 s]
[INFO] Web Container Naming Utilities ..................... SUCCESS [  1.131 s]
[INFO] Web Container Common Utilities ..................... SUCCESS [  1.270 s]
[INFO] Core Servlet Container ............................. SUCCESS [  8.861 s]
[INFO] JSTL implementation connector module ............... SUCCESS [  0.629 s]
[INFO] Jersey MVC TLD connector implementation module ..... SUCCESS [  0.649 s]
[INFO] Web module command line interface .................. SUCCESS [  1.469 s]
[INFO] Web container and GUI plug-in common classes ....... SUCCESS [  0.440 s]
[INFO] WebTier Security Integration ....................... SUCCESS [  0.971 s]
[INFO] GlassFish Web container embedded related modules ... SUCCESS [  0.053 s]
[INFO] GlassFish Web container Embedded APIs .............. SUCCESS [  0.293 s]
[INFO] Server-Sent Events ................................. SUCCESS [  0.338 s]
[INFO] Web Container glue code ............................ SUCCESS [  5.272 s]
[INFO] JSF implementation connector module ................ SUCCESS [  1.003 s]
[INFO] JSP caching taglib connector module ................ SUCCESS [  0.942 s]
[INFO] Web Container HA code .............................. SUCCESS [  1.528 s]
[INFO] Web Related Implementations for GlassFish .......... SUCCESS [  0.070 s]
[INFO] Weld connector for glassfish ....................... SUCCESS [  0.794 s]
[INFO] Weld integration for glassfish ..................... SUCCESS [  3.577 s]
[INFO] Weld Integration Fragment .......................... SUCCESS [  0.095 s]
[INFO] Fragment bundle for Weld related testing ........... SUCCESS [  0.072 s]
[INFO] cdi-api Fragment ................................... SUCCESS [  0.076 s]
[INFO] Full EJB Container add-ons ......................... SUCCESS [  1.362 s]
[INFO] EJB Timer Service Application ...................... SUCCESS [  0.736 s]
[INFO] GlassFish EJB timer app database init scripts ...... SUCCESS [  0.101 s]
[INFO] EJB tier for GlassFish ............................. SUCCESS [  0.066 s]
[INFO] GlassFish resources runtime ........................ SUCCESS [  0.809 s]
[INFO] GlassFish Jakarta Mail runtime ..................... SUCCESS [  0.646 s]
[INFO] Jakarta EE Connector Architecture Descriptors ...... SUCCESS [  0.151 s]
[INFO] Connectors Inbound Support ......................... SUCCESS [  0.956 s]
[INFO] Work Management .................................... SUCCESS [  0.960 s]
[INFO] JDBC Module ........................................ SUCCESS [  0.070 s]
[INFO] JDBC Config Module ................................. SUCCESS [  0.606 s]
[INFO] Connectors admin ................................... SUCCESS [  2.089 s]
[INFO] GlassFish Load-Balancer Plugin related modules ..... SUCCESS [  0.051 s]
[INFO] Load Balancer Internal API ......................... SUCCESS [  0.455 s]
[INFO] Load-Balancer admin ................................ SUCCESS [  1.505 s]
[INFO] GlassFish JMS modules .............................. SUCCESS [  0.056 s]
[INFO] JMS Connector Module for Runtime ................... SUCCESS [  0.431 s]
[INFO] JMS Module ......................................... SUCCESS [  1.638 s]
[INFO] JMS admin .......................................... SUCCESS [  1.514 s]
[INFO] JMS Injection Module for Runtime ................... SUCCESS [  1.315 s]
[INFO] JMS GlassFish System RA Assembly ................... SUCCESS [  0.531 s]
[INFO] JDBC Resource Adapter .............................. SUCCESS [  0.058 s]
[INFO] Core JDBC Resource Adapter classes ................. SUCCESS [  1.375 s]
[INFO] JDBC 40 related classes for JDBC Resource Adapter .. SUCCESS [  0.749 s]
[INFO] JDBC Templates ..................................... SUCCESS [  0.115 s]
[INFO] Distribution Module for JDBC Resource Adapter ...... SUCCESS [  0.448 s]
[INFO] JDBC Runtime Module ................................ SUCCESS [  2.090 s]
[INFO] JDBC admin ......................................... SUCCESS [  1.967 s]
[INFO] GlassFish Oracle JDBC Packages ..................... SUCCESS [  0.089 s]
[INFO] Connector for JPA runtime in glassfish ............. SUCCESS [  0.633 s]
[INFO] JPA container for glassfish ........................ SUCCESS [  0.948 s]
[INFO] Declaring EclipseLink dependencies ................. SUCCESS [  0.089 s]
[INFO] GlassFish cmp related modules ...................... SUCCESS [  0.059 s]
[INFO] utility module for cmp ............................. SUCCESS [  1.161 s]
[INFO] model module for cmp ............................... SUCCESS [  1.606 s]
[INFO] Database Generator module for cmp .................. SUCCESS [  0.980 s]
[INFO] ejb-mapping module for cmp ......................... SUCCESS [  1.283 s]
[INFO] enhancer module for cmp ............................ SUCCESS [  3.667 s]
[INFO] internal-api module for cmp ........................ SUCCESS [  0.812 s]
[INFO] Entity Bean container .............................. SUCCESS [  1.714 s]
[INFO] support-sqlstore module for cmp .................... SUCCESS [  7.993 s]
[INFO] support ejb module for cmp ......................... SUCCESS [  4.094 s]
[INFO] GlassFish cmp scripts .............................. SUCCESS [  0.074 s]
[INFO] CMP tier for GlassFish ............................. SUCCESS [  0.069 s]
[INFO] Concurrency Utilities Modules ...................... SUCCESS [  0.057 s]
[INFO] Concurrent Connector Module ........................ SUCCESS [  0.561 s]
[INFO] Concurrent Implementation Module ................... SUCCESS [  1.727 s]
[INFO] Batch runtime modules for Glassfish ................ SUCCESS [  0.050 s]
[INFO] Batch database init scripts for GlassFish .......... SUCCESS [  0.087 s]
[INFO] Batch Connector for Glassfish ...................... SUCCESS [  0.697 s]
[INFO] Batch Commands for Glassfish ....................... SUCCESS [  0.780 s]
[INFO] GlassFish Extras modules ........................... SUCCESS [  0.053 s]
[INFO] GlassFish JavaEE Manifest pom ...................... SUCCESS [  0.052 s]
[INFO] GlassFish javaee.jar ............................... SUCCESS [  0.069 s]
[INFO] GlassFish javaee.jar distribution fragment ......... SUCCESS [  0.067 s]
[INFO] GlassFish appserv-rt Manifest pom .................. SUCCESS [  0.053 s]
[INFO] GlassFish appserv-rt.jar ........................... SUCCESS [  0.074 s]
[INFO] GlassFish appserv-rt distribution fragment ......... SUCCESS [  0.069 s]
[INFO] GlassFish ORB interface layer implementation ....... SUCCESS [  1.092 s]
[INFO] Ejb Security Integration ........................... SUCCESS [  1.263 s]
[INFO] Grizzly Glassfish Extra modules .................... SUCCESS [  0.052 s]
[INFO] GlassFish Grizzly adapter container implementation . SUCCESS [  0.367 s]
[INFO] Glassfish Grizzly extra jars Combining ............. SUCCESS [  0.647 s]
[INFO] GlassFish Web Services related modules ............. SUCCESS [  0.057 s]
[INFO] JSR-109 implementation to deploy Metro ............. SUCCESS [  3.307 s]
[INFO] GlassFish Metro Glue Code .......................... SUCCESS [  1.185 s]
[INFO] Connector for GlassFish Web Services Container ..... SUCCESS [  1.500 s]
[INFO] SOAP/TCP integration code .......................... SUCCESS [  1.301 s]
[INFO] WebServices Security and JSR 196 implementation .... SUCCESS [  1.499 s]
[INFO] App Client - client-side modules ................... SUCCESS [  0.053 s]
[INFO] ACC Config Classes (JAXB) .......................... SUCCESS [  1.026 s]
[INFO] Appclient Security Integration ..................... SUCCESS [  0.878 s]
[INFO] Client OSGi module (including ACC) ................. SUCCESS [  6.269 s]
[INFO] GlassFish AppClient Server-Side Core ............... SUCCESS [  1.847 s]
[INFO] Embedded GlassFish Shell ........................... SUCCESS [  0.089 s]
[INFO] Embedded GlassFish Shell dist. fragment ............ SUCCESS [  0.085 s]
[INFO] GlassFish webservices scripts ...................... SUCCESS [  0.085 s]
[INFO] GlassFish Metro Related Fragments .................. SUCCESS [  0.086 s]
[INFO] Embedded GlassFish Static Shell .................... SUCCESS [  0.243 s]
[INFO] Embedded GlassFish Static Shell dist. fragment ..... SUCCESS [  0.086 s]
[INFO] Embedded GlassFish All-In-One ...................... SUCCESS [01:31 min]
[INFO] Embedded GlassFish nucleus ......................... SUCCESS [  2.526 s]
[INFO] Embedded GlassFish Web ............................. SUCCESS [ 45.012 s]
[INFO] GlassFish Embedded modules ......................... SUCCESS [  0.063 s]
[INFO] GlassFish Embedded Modules - Tests ................. SUCCESS [  0.371 s]
[INFO] DataProvider ....................................... SUCCESS [  0.239 s]
[INFO] Admin Console Integration .......................... SUCCESS [  0.547 s]
[INFO] Admin Console Integration .......................... SUCCESS [  0.400 s]
[INFO] Admin Console Packages ............................. SUCCESS [  0.077 s]
[INFO] Admin Console Common ............................... SUCCESS [  4.043 s]
[INFO] Admin Console Core Jar ............................. SUCCESS [  1.222 s]
[INFO] Admin Console Concurrent Plugin .................... SUCCESS [  0.524 s]
[INFO] Admin Console Clustering Support Plugin ............ SUCCESS [  0.907 s]
[INFO] Admin Console Community Edition Theme Plugin ....... SUCCESS [  0.492 s]
[INFO] Admin Console Web Container Plugin ................. SUCCESS [  0.792 s]
[INFO] Admin Console JTS Plugin ........................... SUCCESS [  0.385 s]
[INFO] Admin Console JDBC Plugin .......................... SUCCESS [  0.497 s]
[INFO] Admin Console Connectors Plugin .................... SUCCESS [  0.659 s]
[INFO] Admin Console JMS Plugin ........................... SUCCESS [  1.465 s]
[INFO] Admin Console EJB Container Plugin ................. SUCCESS [  0.368 s]
[INFO] Admin Console EJB Local (Lite) Plugin .............. SUCCESS [  0.381 s]
[INFO] Admin Console Corba Plugin ......................... SUCCESS [  0.482 s]
[INFO] Admin Console Full distribution plugin ............. SUCCESS [  0.576 s]
[INFO] Admin Console WAR .................................. SUCCESS [  0.267 s]
[INFO] Admin Console Install Fragment for Web distro ...... SUCCESS [  0.406 s]
[INFO] Embedded GlassFish Shell Jars ...................... SUCCESS [  0.060 s]
[INFO] Glassfish featuresets .............................. SUCCESS [  0.062 s]
[INFO] Glassfish Web Featureset ........................... SUCCESS [  0.103 s]
[INFO] Client Library (including ACC) ..................... SUCCESS [  2.007 s]
[INFO] GlassFish appclient scripts ........................ SUCCESS [  0.090 s]
[INFO] Glassfish Featureset ............................... SUCCESS [  0.106 s]
[INFO] Glassfish distributions ............................ SUCCESS [  0.059 s]
[INFO] GlassFish distribution Common module ............... SUCCESS [  0.732 s]
[INFO] Glassfish Web Profile Distribution ................. SUCCESS [ 21.413 s]
[INFO] Glassfish Full Profile Distribution ................ SUCCESS [ 27.049 s]
[INFO] Security Related Implementation for GlassFish ...... SUCCESS [  0.068 s]
[INFO] GlassFish Tests .................................... SUCCESS [  0.056 s]
[INFO] TCK: Parent ........................................ SUCCESS [  0.059 s]
[INFO] TCK: Download and Install Dependencies not in Maven Repos SUCCESS [  0.057 s]
[INFO] TCK: Install Jakarta Authorization TCK ............. SUCCESS [  0.139 s]
[INFO] TCK: Install Jakarta Authorization`s tsharness ..... SUCCESS [  0.108 s]
[INFO] TCK: Install Jakarta Authorization`s javatest ...... SUCCESS [  1.981 s]
[INFO] TCK: Authorization ................................. SUCCESS [03:54 min]
[INFO] TCK: Embedded EJB - Smoke Tests .................... SUCCESS [  0.090 s]
[INFO] TCK: EJB Lite Basic ................................ SUCCESS [  1.277 s]
[INFO] TCK: Run embedded EJB smoke ........................ SUCCESS [  4.937 s]
[INFO] Console extensions for OSGi platforms .............. SUCCESS [  0.076 s]
[INFO] Felix Web Console Extension for GlassFish .......... SUCCESS [  0.665 s]
[INFO] GlassFish OSGi Console Plugin ...................... SUCCESS [  0.673 s]
[INFO] GlassFish Flashlight Client ........................ SUCCESS [  0.478 s]
[INFO] Flashlight ......................................... SUCCESS [  0.085 s]
[INFO] Ant tasks .......................................... SUCCESS [  0.586 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12:40 min
[INFO] Finished at: 2022-02-04T12:58:27-06:00
[INFO] ------------------------------------------------------------------------

The -DskipTests property is not preventing the some of the TCK tests from running. Maybe the build command in the CI job should be updated to use the 'mvn clean install -Pfastest ...' from the glassfish readme.

I'm going to look at the snapshots/tags module in more detail to see how it is building on my machine.

@starksm64
Copy link
Contributor

I removed my local ~/.m2/repository/org/glassfish/web and can build the snapshots/tags module even without the -Psnapshots profile, but I also don't see any attempt to resolve the org.glassfish.web:tagsdoc:1.0-SNAPSHOT/maven-metadata.xml even with debug mode enabled:

mvn -Pstaging -X install
...
[INFO] [INFO] --- exec-maven-plugin:3.0.0:java (generateTldDoc) @ jakarta.servlet.jsp.jstl ---
[INFO] Loading and translating 5 Tag Libraries...
[INFO] Generating docs for JSTL sql...
[INFO] Generating docs for JSTL XML...
[INFO] Generating docs for JSTL fmt...
[INFO] Generating docs for JSTL core...
[INFO] Generating docs for JSTL functions...
[INFO] 
[INFO] Documentation generated.  If your tag library is intended for public use, 
[INFO] please add it to the repository at http://taglibrarydoc.dev.java.net/
[INFO] [INFO] 
[INFO] [INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ jakarta.servlet.jsp.jstl ---
[INFO] [INFO] Building jar: /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT.jar
[INFO] [INFO] 
[INFO] [INFO] --- maven-shade-plugin:3.2.4:shade (default) @ jakarta.servlet.jsp.jstl ---
[INFO] [INFO] Including xalan:xalan:jar:2.7.2 in the shaded jar.
[INFO] [INFO] Excluding jakarta.servlet.jsp.jstl:jakarta.servlet.jsp.jstl-api:jar:3.0.0-SNAPSHOT from the shaded jar.
[INFO] [INFO] Excluding xalan:serializer:jar:2.7.2 from the shaded jar.
[INFO] [INFO] Excluding xml-apis:xml-apis:jar:1.3.04 from the shaded jar.
[INFO] [INFO] Replacing original artifact with shaded artifact.
[INFO] [INFO] Replacing /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT.jar with /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT-shaded.jar
[INFO] [INFO] Dependency-reduced POM written at: /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/dependency-reduced-pom.xml
[INFO] [INFO] 
[INFO] [INFO] --- maven-antrun-plugin:3.0.0:run (generate-tlddoc-post-process) @ jakarta.servlet.jsp.jstl ---
[INFO] [INFO] Executing tasks
[INFO] [INFO]      [echo] Replacing in /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/tlddoc
[INFO] [INFO]   [replace] Replaced 3 occurrences in 3 files.
[INFO] [INFO] Executed tasks
[INFO] [INFO] 
[INFO] [INFO] --- maven-source-plugin:3.2.1:jar-no-fork (attach-sources) @ jakarta.servlet.jsp.jstl ---
[INFO] [INFO] Building jar: /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT-sources.jar
[INFO] [INFO] 
[INFO] [INFO] --- maven-javadoc-plugin:3.3.1:jar (attach-javadocs) @ jakarta.servlet.jsp.jstl ---
[INFO] [INFO] No previous run data found, generating javadoc.
[INFO] [INFO] Building jar: /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT-javadoc.jar
[INFO] [INFO] 
[INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ jakarta.servlet.jsp.jstl ---
[INFO] [INFO] Installing /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT.jar to /Users/starksm/.m2/repository/org/glassfish/web/jakarta.servlet.jsp.jstl/3.0.0-SNAPSHOT/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT.jar
[INFO] [INFO] Installing /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/dependency-reduced-pom.xml to /Users/starksm/.m2/repository/org/glassfish/web/jakarta.servlet.jsp.jstl/3.0.0-SNAPSHOT/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT.pom
[INFO] [INFO] Installing /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT-sources.jar to /Users/starksm/.m2/repository/org/glassfish/web/jakarta.servlet.jsp.jstl/3.0.0-SNAPSHOT/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT-sources.jar
[INFO] [INFO] Installing /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl/target/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT-javadoc.jar to /Users/starksm/.m2/repository/org/glassfish/web/jakarta.servlet.jsp.jstl/3.0.0-SNAPSHOT/jakarta.servlet.jsp.jstl-3.0.0-SNAPSHOT-javadoc.jar
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD SUCCESS
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time:  17.365 s
[INFO] [INFO] Finished at: 2022-02-04T13:18:00-06:00
[INFO] [INFO] ------------------------------------------------------------------------
[DEBUG] post-build script: no script 'postbuild' found in directory /Users/starksm/Dev/JBoss/Jakarta/EE10/glassfish/snapshots/tags/target/jstl-api-master/impl
[INFO]           pom.xml .......................................... SUCCESS (18.7 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 1, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------

@starksm64
Copy link
Contributor

What does running mvn -Pstaging -X install from your glassfish/snapshots/tags repo dir on your local machine show?

@starksm64
Copy link
Contributor

starksm64 commented Feb 4, 2022 •
edited
Loading

I created a simple freestyle job in the CDI CI project to just build the glassfish master and it is also seeing the same failure:

TOOLS_PREFIX='/opt/tools'
MVN_HOME="${TOOLS_PREFIX}/apache-maven/latest"
PATH="${MVN_HOME}/bin:${JAVA_HOME}/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

git clone https://github.com/eclipse-ee4j/glassfish.git
cd glassfish
git checkout master
mvn -Pfastest -Pstaging clean install -DskipTests
ls -l appserver/distributions/glassfish/target/

Output of job is here: https://ci.eclipse.org/cdi/job/GlassFish7Build/2/console

I'll create a bug on the EF CI infrastructure.

@starksm64
Copy link
Contributor

After looking into the error more, this seems to be a problem with the glassfish build using a non-https URL to access a maven repository. I have created the following glassfish issue:

eclipse-ee4j/glassfish#23779

@tomjenkinson
Copy link
Contributor Author

retest this please

tomjenkinson
tomjenkinson commented Feb 7, 2022
View reviewed changes
api/pom.xml Outdated
javax.interceptor.*;version="1.2",
jakarta.enterprise.context;version=!,
jakarta.enterprise.util;version=!,
jakarta.interceptor;version="2.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version="2.1" seems like it might not be working:

[caused by: Unable to resolve jakarta.transaction-api [153](R 153.0): missing requirement [jakarta.transaction-api [153](R 153.0)] osgi.wiring.package; (&(osgi.wiring.package=jakarta.interceptor)(version>=2.1.0))]] Unresolved requirements: [[org.glassfish.main.resources.mail-connector [207](R 207.0)] osgi.wiring.package; (&(osgi.wiring.package=jakarta.resource)(version>=2.0.0)(!(version>=3.0.0)))]

tomjenkinson
tomjenkinson commented Feb 7, 2022
View reviewed changes
api/pom.xml
javax.interceptor.*;version="1.2",
jakarta.enterprise.context;version=!,
jakarta.enterprise.util;version=!,
jakarta.interceptor;version="2.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version of intercept builds with 2.1.0 (IIRC) but the one in glassfish 7.0.0 nightly (that I just downloaded from https://download.eclipse.org/ee4j/glassfish/) has 2.0.1 so going with that in here

@tomjenkinson
Updated OSGi packages data
b5848ca 
Signed-off-by: Tom Jenkinson <[email protected]>
tomjenkinson
tomjenkinson commented Feb 7, 2022
View reviewed changes
api/pom.xml
javax.transaction.xa,
*
</Import-Package>
<Export-Package>
javax.transaction;version="1.2";uses:="javax.interceptor,javax.transaction.xa,javax.enterprise.util,javax.enterprise.context",
javax.transaction;version="1.3";uses:="javax.interceptor,javax.transaction.xa,javax.enterprise.util,javax.enterprise.context"
jakarta.transaction;version="2.0.1";uses:="javax.transaction.xa,jakarta.interceptor,jakarta.enterprise.context,jakarta.enterprise.util"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jakarta Transactions project no longer exports the javax.transaction package (https://github.com/eclipse-ee4j/jta-api/tree/master/api/src/main/java) - OSGI Release 6 3.6.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSGI spec reference should be for R8 (https://www.mail-archive.com/[email protected]/msg18662.html) https://github.com/eclipse-ee4j/glassfish/blob/611adfbfaf2a7b2c1b5e97943652ccc43700b28a/nucleus/parent/pom.xml#L296

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.osgi.org/specification/osgi.core/8.0.0/framework.module.html#framework.module.exportpackage

tomjenkinson
tomjenkinson commented Feb 7, 2022
View reviewed changes
api/pom.xml
javax.enterprise.context;version=!,
javax.enterprise.util;version=!,
javax.interceptor.*;version="1.2",
jakarta.enterprise.context;version=!,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

! rationale is at https://github.com/eclipse-ee4j/jta-api/pull/187/files#r595102746

@tomjenkinson tomjenkinson merged commit 9d6bb0e into jakartaee:master Feb 7, 2022
@tomjenkinson
Copy link
Contributor Author

Thank you @LanceAndersen !

@grgrzybek
Copy link
Contributor

BTW, is there analogous change in https://github.com/eclipse-ee4j/jca-api? See some comments under jakartaee/connectors#120.

@tomjenkinson
Copy link
Contributor Author

tomjenkinson commented Feb 8, 2022 •
edited
Loading

Jakarta Connectors on master seems it should be already working as it's connected to jakarta.transaction (for EE9 presumably) and 2.0.1 is in their range already (assuming OSGi Core Release 8 sections 3.2.6 and 3.7.3 is applicable and adhered to): https://github.com/eclipse-ee4j/jca-api/blob/master/api/pom.xml#L170

They possibly missed this intermediary stage where the Jakarta Transactions jar would be declaring to export packages from javax.transaction (and we exported javax.transaction previously in EE8 https://jakarta.ee/specifications/transactions/1.3/).

In summary, I hope there should be no reason for Jakarta Connectors to change

@tomjenkinson tomjenkinson deleted the osgi-metadata branch February 8, 2022 11:52
@tomjenkinson
Copy link
Contributor Author

Resolved #201

@tomjenkinson tomjenkinson restored the osgi-metadata branch January 14, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starksm64 starksm64 starksm64 approved these changes

@LanceAndersen LanceAndersen LanceAndersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomjenkinson @starksm64 @grgrzybek @LanceAndersen