Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tck_challenge.md #217

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Emily-Jiang
Copy link

No description provided.

@jta-bot
Copy link
Contributor

jta-bot commented Sep 19, 2024

Can one of the admins verify this patch?

@tomjenkinson
Copy link
Contributor

@Emily-Jiang it looks good to me and I though I could likely be able to review it without the following request, in case it's available I would ask if this format is a template/document from someplace we can reference as a motivating factor for the introduction of, please?

@Emily-Jiang
Copy link
Author

@Emily-Jiang it looks good to me and I though I could likely be able to review it without the following request, in case it's available I would ask if this format is a template/document from someplace we can reference as a motivating factor for the introduction of, please?

Not sure whether you can view this. This request is from Jakarta EE specification committee.
You can find another example of this tck challenge here.

Copy link

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes requested.

assignees: ''

---

Copy link
Contributor

@tomjenkinson tomjenkinson Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should prompt people to review https://jakarta.ee/committees/specification/tckprocess/ as part of the process.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand what you meant. It is not my aim to prompt people to review the process. If you want to achieve that, please feel free to propose a PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone came here to raise a challenge, they might have visited the tck process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important that the challenge is filed by an appropriate person: https://jakarta.ee/committees/specification/tckprocess/#_who_can_file_a_challenge - is there someway that during raising the challenge information can be provided so it can be verified an implementor is raising the issue?

I think you should also provide space for the other parts of the requirements when filing a challenge:
https://jakarta.ee/committees/specification/tckprocess/#_filing_a_challenge. I think most of this fits nicely in your format but perhaps the following should have their own sections?:

  • The relevant specification version and section number(s)
  • The implementation being tested, including name and company (maybe this is the first part of this comment?)

@tomjenkinson
Copy link
Contributor

Do you know how GitHub behaves if only one one template exists in the repo? In other words, do you know if someone would be able to raise an issue on this project but not using the new template (after this pull request is merged)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants