Make config test exit with error code if broken #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idea/suggestion/nitpick: use something that is not exit code 2. Why? argparse, by default, exits when there is an invalid command line parameter with error code 2 (see https://docs.python.org/es/3/library/argparse.html#exit-on-error). And since exit code 1 is for, usually, exceptions (IIRC) then use exit code 3 for invalid configuration? In practical terms for systemd integration it doesn't matter, so I am happy either way! |
|
Nice catch, |
Will prevent broken monitors from aborting the whole loop, instead just skipping that monitor. Improves logging to aid diagnostics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @cpina, make
-texit non-zero (I picked2) if something isn't right with the config. Mostly this covers using a monitor/alerter/logger type which isn't known; other config errors currently will just throw an exception and exit 1 still.If not testing the config, then the previous behaviour is currently retained: SimpleMonitor will try to continue with the config it did load. Not sure if that's the best choice yet; it probably should exit if the config is broken either way.