fix(alerters): use regular text email instead of MIME #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove some extra newlines at the beginning of email alerts - Use regular plaintext email vs. MIME so that we receive the plain text email inline instead of as a single text/plain attachment. While MIME has some advantages if we were sending attachments, using multipart/mixed messages to send both HTML and plaintext versions, it doesn't appear to me that we're doing that
wyardley
commented
Mar 5, 2025
| @@ -434,7 +434,7 @@ def build_message( | |||
| raise NotImplementedError | |||
| elif length == AlertLength.FULL: | |||
| if alert_type in [AlertType.CATCHUP, AlertType.FAILURE]: | |||
| message = """ | |||
| message = """\ | |||
There was a problem hiding this comment.
there might be other ways to suppress these newlines; this way seemed to work
| @@ -62,7 +61,7 @@ def send_alert(self, name: str, monitor: Monitor) -> None: | |||
| AlertLength.NOTIFICATION, alert_type, monitor | |||
| ) | |||
| body = self.build_message(AlertLength.FULL, alert_type, monitor) | |||
| message.attach(MIMEText(body, "plain")) | |||
| message.set_content(body) | |||
There was a problem hiding this comment.
I don't know if there are cases where we're sending anything other than plain ASCII text? but the tests pass 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While MIME has some advantages if we were sending attachments, using multipart/mixed messages to send both HTML and plaintext versions, it doesn't appear to me that we're doing that
before (notice extra line and attachment)
after:
