Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tests #96

Closed
wants to merge 2 commits into from
Closed

Fixing tests #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46e421b
- fix: update charset assertion to use correct casing in httpx_test.rb
softwaregravy Jan 26, 2025
b9619e0
- fix: update encoding representation in ChunkedIO inspect method to …
softwaregravy Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/chunked_io_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,19 +829,19 @@ def chunked_io(**options)

describe "#inspect" do
it "shows important information" do
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:ASCII-8BIT> data={} on_close=nil rewindable=true>",
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:BINARY (ASCII-8BIT)> data={} on_close=nil rewindable=true>",
chunked_io(chunks: [""].each).inspect
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=10 encoding=#<Encoding:ASCII-8BIT> data={} on_close=nil rewindable=true>",
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=10 encoding=#<Encoding:BINARY (ASCII-8BIT)> data={} on_close=nil rewindable=true>",
chunked_io(chunks: [""].each, size: 10).inspect
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:UTF-8> data={} on_close=nil rewindable=true>",
chunked_io(chunks: [""].each, encoding: "utf-8").inspect
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:ASCII-8BIT> data={:foo=>\"bar\"} on_close=nil rewindable=true>",
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:BINARY (ASCII-8BIT)> data={foo: \"bar\"} on_close=nil rewindable=true>",
chunked_io(chunks: [""].each, data: {foo: "bar"}).inspect
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:ASCII-8BIT> data={} on_close=:callable rewindable=true>",
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:BINARY (ASCII-8BIT)> data={} on_close=:callable rewindable=true>",
chunked_io(chunks: [""].each, on_close: :callable).inspect
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:ASCII-8BIT> data={} on_close=nil rewindable=false>",
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:BINARY (ASCII-8BIT)> data={} on_close=nil rewindable=false>",
chunked_io(chunks: [""].each, rewindable: false).inspect
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:ASCII-8BIT> data={} on_close=nil rewindable=true (closed)>",
assert_equal "#<Down::ChunkedIO chunks=#<Enumerator: [\"\"]:each> size=nil encoding=#<Encoding:BINARY (ASCII-8BIT)> data={} on_close=nil rewindable=true (closed)>",
chunked_io(chunks: [""].each).tap(&:close).inspect
end
end
Expand Down
4 changes: 2 additions & 2 deletions test/httpx_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
it "adds #charset extracted from Content-Type" do
tempfile = Down::Httpx.download("#{$httpbin}/html")
assert_equal "text/html", tempfile.content_type
assert_equal "utf-8", tempfile.charset
assert_equal "UTF-8", tempfile.charset.name
end

it "accepts download destination" do
Expand Down Expand Up @@ -303,4 +303,4 @@
assert_raises(HTTPX::Error) { Down::Httpx.open("http://32r3ida") }
end
end
end
end
Loading