Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete interview #26

Merged
merged 1 commit into from
Dec 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

import com.tnite.jobwinner.model.Interview;
import com.tnite.jobwinner.model.InterviewInput;
import com.tnite.jobwinner.model.Offer;
import com.tnite.jobwinner.service.InterviewService;
import io.micrometer.common.lang.NonNull;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.graphql.data.method.annotation.Argument;
import org.springframework.graphql.data.method.annotation.MutationMapping;
Expand All @@ -29,6 +31,11 @@ public Mono<Interview> updateInterview(@Argument Interview interview) {
return interviewService.updateInterview(interview);
}

@MutationMapping
public Mono<Interview> deleteInterview(@Argument @NonNull Integer id) {
return interviewService.deleteInterview(id);
}

@QueryMapping
public Flux<Interview> allInterviewByJobApplicationId(@Argument Integer jobApplicationId) {
return interviewService.getInterviewByJobApplicationId(jobApplicationId);
Expand Down
11 changes: 11 additions & 0 deletions src/main/java/com/tnite/jobwinner/service/InterviewService.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@

import com.tnite.jobwinner.model.Interview;
import com.tnite.jobwinner.model.InterviewInput;
import com.tnite.jobwinner.model.Offer;
import com.tnite.jobwinner.repo.InterviewRepository;
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;

import java.util.Objects;

@Service
@Slf4j
public class InterviewService {
Expand Down Expand Up @@ -43,6 +46,14 @@ public Mono<Interview> updateInterview(Interview interview) {
.doOnError(e -> log.error("Failed to update interview: {}", interview, e));
}

public Mono<Interview> deleteInterview(Integer id) {
log.info("Deleting interview id {}", id);
return this.interviewRepository.findById(id).switchIfEmpty(Mono.empty()).filter(Objects::nonNull)
.flatMap(interviewToBeDeleted -> interviewRepository
.delete(interviewToBeDeleted)
.then(Mono.just(interviewToBeDeleted))).log();
}

private void updateInterviewDetails(Interview existingInterview, Interview updatedInterview) {
existingInterview.setJobApplicationId(updatedInterview.getJobApplicationId());
existingInterview.setInterviewDate(updatedInterview.getInterviewDate());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,6 @@ public class JobApplicationService {
return jobApplication;
};

Function<JobApplication, JobApplication> editMapping = ji -> {
var jobApplication = new JobApplication();
jobApplication.setId(ji.getId());
jobApplication.setCompanyName(ji.getCompanyName());
jobApplication.setJobTitle(ji.getJobTitle());
jobApplication.setSalaryRange(ji.getSalaryRange());
jobApplication.setJobUrl(ji.getJobUrl());
jobApplication.setAppliedDate(ji.getAppliedDate());
jobApplication.setDescription(ji.getDescription());
jobApplication.setStatus(ji.getStatus());
return jobApplication;
};

public Mono<JobApplication> addJobApplication(JobApplicationInput addJobApplicationInput) {
Mono<JobApplication> jobApplication = jobApplicationRepository.save(mapping.apply(addJobApplicationInput));
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/graphql/schema.graphqls
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ type Mutation {
updateProfile(profile: UpdateProfileInput): Profile
addInterview(interviewInput: AddInterviewInput): Interview
updateInterview(id: ID!, interview: UpdateInterviewInput): Interview
deleteInterview(id: ID): Interview
addOffer(offerInput: OfferInput): Offer
updateOffer(offer: UpdateOfferInput): Offer
deleteOffer(id: ID): Offer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;

import java.time.LocalDate;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyInt;
Expand Down Expand Up @@ -46,6 +48,29 @@ void testUpdateInterview() {
assertEquals(Interview, result.block());
}

@Test
void testDeleteInterview() {
Interview interview = new Interview();
when(interviewService.deleteInterview(anyInt())).thenReturn(Mono.just(interview));

Mono<Interview> result = interviewController.deleteInterview(1);

assertEquals(interview, result.block());
}

@Test
void testAllInterviewByJobApplicationId() {
Interview interview1 = new Interview(1, 1, LocalDate.now(), "John Doe", "HR Interview", "scheduled");
Interview interview2 = new Interview(2, 1, LocalDate.now(), "Jane Doe", "Technical Interview", "scheduled");
when(interviewService.getInterviewByJobApplicationId(1)).thenReturn(Flux.just(interview1, interview2));

Flux<Interview> result = interviewController.allInterviewByJobApplicationId(1);

assertEquals(2, result.collectList().block().size());
assertEquals(interview1, result.collectList().block().get(0));
assertEquals(interview2, result.collectList().block().get(1));
}

@Test
void testAllInterview() {
Interview interview1 = new Interview();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,4 +227,32 @@ void testUpdateInterview() {
verify(interviewRepository, times(1)).findById(1);
verify(interviewRepository, times(1)).save(any(Interview.class));
}

@Test
void testDeleteOffer() {
when(interviewRepository.findById(1)).thenReturn(Mono.just(interview1));
when(interviewRepository.delete(interview1)).thenReturn(Mono.empty());

String document = """
mutation {
deleteInterview(id:1) {
id
jobApplicationId
interviewDate
interviewer
description
status
}
}
""";

graphQlTester.document(document)
.execute()
.path("deleteInterview.description")
.entity(String.class)
.isEqualTo("Technical interview");

verify(interviewRepository, times(1)).findById(1);
verify(interviewRepository, times(1)).delete(interview1);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,34 @@ void testUpdateInterview() {
verify(interviewRepository, times(1)).save(any(Interview.class));
}

@Test
void testDeleteInterviewWhenInterviewExistsThenReturnsInterview() {
when(interviewRepository.findById(1)).thenReturn(Mono.just(interview1));
when(interviewRepository.delete(interview1)).thenReturn(Mono.empty());

Mono<Interview> result = interviewService.deleteInterview(1);

StepVerifier.create(result)
.expectNextMatches(interview -> interview.getDescription().equals("Technical Interview"))
.verifyComplete();

verify(interviewRepository, times(1)).findById(1);
verify(interviewRepository, times(1)).delete(interview1);
}

@Test
void testDeleteInterviewWhenInterviewNotExists() {
when(interviewRepository.findById(1)).thenReturn(Mono.empty());

Mono<Interview> result = interviewService.deleteInterview(1);

StepVerifier.create(result)
.verifyComplete();

verify(interviewRepository, times(1)).findById(1);
verifyNoMoreInteractions(interviewRepository);
}

@Test
void getInterviewByJobApplicationId() {
when(interviewRepository.findAllByJobApplicationId(1)).thenReturn(Flux.just(interview1, interview2));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import com.tnite.jobwinner.model.JobApplicationInput;
import com.tnite.jobwinner.model.JobApplication;
import com.tnite.jobwinner.model.Offer;
import com.tnite.jobwinner.repo.JobApplicationRepository;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand All @@ -14,6 +13,7 @@
import reactor.core.publisher.Mono;
import reactor.test.StepVerifier;

import java.time.LocalDate;
import java.util.Arrays;
import java.util.List;

Expand Down Expand Up @@ -58,6 +58,28 @@ void setUp() {
jobApplicationList = Arrays.asList(jobApplication1, jobApplication2);
}

@Test
void testMapping() {
JobApplicationInput input = new JobApplicationInput();
input.setCompanyName("Company A");
input.setJobTitle("Developer");
input.setSalaryRange("100000");
input.setJobUrl("https://example.com");
input.setAppliedDate(LocalDate.now());
input.setDescription("whatever");
input.setStatus("Open");

JobApplication result = jobApplicationService.mapping.apply(input);

assertEquals(input.getCompanyName(), result.getCompanyName());
assertEquals(input.getJobTitle(), result.getJobTitle());
assertEquals(input.getSalaryRange(), result.getSalaryRange());
assertEquals(input.getJobUrl(), result.getJobUrl());
assertEquals(input.getAppliedDate(), result.getAppliedDate());
assertEquals(input.getDescription(), result.getDescription());
assertEquals(input.getStatus(), result.getStatus());
}

@Test
void testAddJobApplication() {
when(jobApplicationRepository.save(any(JobApplication.class))).thenReturn(Mono.just(jobApplication1));
Expand Down
Loading