pkp/pkp-lib#7495 connect reviewerFullName

jardakotesovec · Jun 12, 2024 · 86cd11f · 86cd11f
1 parent 04174cf
commit 86cd11f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/src/composables/useReviewAssignment.js b/src/composables/useReviewAssignment.js
@@ -31,13 +31,11 @@ export function useReviewAssignment() {
 	}
 
 	function getOpenReviewAssignments(reviewAssignments = []) {
-		// TODO: we don't have reviewMethod in API yet, therefore dummy logic
-		return getActiveReviewAssignments(reviewAssignments).slice(0, 2);
-		/*return reviewAssignments.filter(
+		return reviewAssignments.filter(
 			(reviewAssignment) =>
 				reviewAssignment.reviewMethod ===
 				pkp.const.SUBMISSION_REVIEW_METHOD_OPEN,
-		);*/
+		);
 	}
 
 	function getReviewMethodIcons(reviewAssignment) {

diff --git a/...rd/components/DashboardTable/CellSubmissionActivity/CellSubmissionActivityReviewsOpen.vue b/...rd/components/DashboardTable/CellSubmissionActivity/CellSubmissionActivityReviewsOpen.vue
@@ -7,12 +7,11 @@
 				:key="reviewAssignment.id"
 			>
 				<PkpPopover>
-					<!-- TODO once the reviewer name and method are in the response, use it-->
 					<template #button>
 						<UserAvatar
 							size-variant="small"
 							:user-id="reviewAssignment.id"
-							:user-full-name="String(reviewAssignment.id)"
+							:user-full-name="String(reviewAssignment.revieweFullname)"
 						/>
 					</template>
 					<ReviewActivityIndicatorPopover

diff --git a/...es/dashboard/components/ReviewActivityIndicatorPopover/ReviewActivityIndicatorPopover.vue b/...es/dashboard/components/ReviewActivityIndicatorPopover/ReviewActivityIndicatorPopover.vue
@@ -59,7 +59,7 @@ defineProps({
 	title: {type: String, required: false, default: null},
 	description: {type: String, required: false, default: null},
 	reviewMethodIcons: {type: Array, required: true},
-	reviewerName: {type: String, required: true, default: 'TODO'},
+	reviewerName: {type: String, required: true, default: ''},
 	primaryButton: {type: Object, required: false, default: null},
 	negativeButton: {type: Object, required: false, default: null},
 	textButton: {type: Object, required: false, default: null},

diff --git a/src/pages/dashboard/composables/useReviewActivityLogic.js b/src/pages/dashboard/composables/useReviewActivityLogic.js
@@ -402,7 +402,7 @@ export function useReviewActivityLogic() {
 				action: config.negativeAction,
 				label: getNegativeActionLabel(),
 			},
-			reviewerName: 'Reviewer Name (todo)',
+			reviewerName: reviewAssignment.reviewerFullName,
 		};
 	}
 	return {