-
-
Notifications
You must be signed in to change notification settings - Fork 139
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
43 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eclipseo, @maxice8, @pabloariasal, @szlin, @zmwangx ddgr v1.7 is released!
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated on F30 to F32. Added to EPEL7 and EPEL8.
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmwangx can you please update
ddgr
to 1.7 on PyPi?956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Two things:
PyPI has had Markdown support for quite a while now.
long_description
should be changed toREADME.md
content, with a new keylong_description_content_type='text/markdown'
.I'm glad to update this as long as I'm around, but just in case I disappear for an extended period of time like I did last time, would you like me to add you to https://pypi.org/project/ddgr/?
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice! I'll update this now.
Sure thing! Please add me. And don't worry. You'll be around longer than me to take care of these. ;)
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be
long_description
=README.md orlong_description
='README.md'? Or both work?956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re long_description: it's more complicated than that, but you can basically copy the code from PyPA sample project and use it everywhere: https://github.com/pypa/sampleproject/blob/2cf198529c6c5a4fa50c28505ce6a90266b89868/setup.py#L17-L21. (PyPA sample project is universal and hence does a lot to accommodate py27. You can drop the
io.open
andactually just keep thatencoding='utf-8'
encoding
, you never know about Windows).Re adding to the PyPI project: I just need your PyPI username.
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just need your PyPI username: arunj
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed at commit 50b9554.
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmwangx what does it take to include the CHANGELOG and LICENSE in the PyPI package?
Can we simply add a MANIFEST.in (like https://github.com/jarun/pdd/blob/master/MANIFEST.in) and those will get uploaded?
956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to
MANIFEST.in
, I also recommend adding thelicense_file
key tosetuptools.setup
.956435a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!