Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class fraction #91

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Class fraction #91

wants to merge 13 commits into from

Conversation

jatkinson1000
Copy link
Owner

Adds the functionality of giving the 'fraction through a classification' a score is based on the handicap.

As requested by users.

Copy link
Owner Author

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably use type of classification in the function name for consistency elsewhere. No other schemes can use this at present, but field will need it in #46

@jatkinson1000
Copy link
Owner Author

Need to add a check for when handicap and score can overlap slightly either way at boundaries after being rounded to integers.

Roughly:

  • If score is a boundary value (in classification_scores) set to... 0.0? 1.0?... 0.0 makes sense I think as 1 occurs when we are at the highest classification we can be.
  • Though on this note check what to do when we hit the top bound - should always be 1.0

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.95%. Comparing base (cd4dc92) to head (bcdda67).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   97.64%   97.95%   +0.30%     
==========================================
  Files          28       28              
  Lines        1613     1710      +97     
==========================================
+ Hits         1575     1675     +100     
+ Misses         38       35       -3     
Files Coverage Δ
archeryutils/classifications/__init__.py 100.00% <ø> (ø)
...tils/classifications/agb_indoor_classifications.py 100.00% <100.00%> (ø)
...ils/classifications/agb_outdoor_classifications.py 100.00% <100.00%> (ø)
...heryutils/classifications/tests/test_agb_indoor.py 100.00% <100.00%> (ø)
...eryutils/classifications/tests/test_agb_outdoor.py 100.00% <100.00%> (ø)
archeryutils/handicaps/tests/test_handicaps.py 100.00% <100.00%> (ø)
archeryutils/utils.py 100.00% <ø> (ø)

... and 8 files with indirect coverage changes

Copy link
Owner Author

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is now OK to go.
Consider bumping to 1.1.0 and adding a release, or instead wait until larger changes such as #46 come in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants