-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class fraction #91
base: main
Are you sure you want to change the base?
Class fraction #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably use type of classification in the function name for consistency elsewhere. No other schemes can use this at present, but field will need it in #46
Need to add a check for when handicap and score can overlap slightly either way at boundaries after being rounded to integers. Roughly:
|
4625170
to
29fce01
Compare
…tdoor with boundary scores.
… score in outdoor and ignore related line in indoor that will not be triggered.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 97.64% 97.95% +0.30%
==========================================
Files 28 28
Lines 1613 1710 +97
==========================================
+ Hits 1575 1675 +100
+ Misses 38 35 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is now OK to go.
Consider bumping to 1.1.0 and adding a release, or instead wait until larger changes such as #46 come in.
Adds the functionality of giving the 'fraction through a classification' a score is based on the handicap.
As requested by users.