Add initial arm64 support #142
Merged
+131
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the arm64 (aarch64) architecture. This is
achived by adapting the compact unwind information generation to deal
with the DWARF registers that this architecture maps to and by modifying
the unwinder.
These changes support PAC (Pointer Authentication Code), see test plan
for more details.
While working on this feature I realised that the vDSO included in
Ubuntu 24.10 (6.11.0-12-generic) does not contain unwind information. In
the future we should synthetise it which should be easy enough as it
seems to be compiled with frame pointers.
Test Plan
=========
Ran tests locally on the arm64 machine mentioned above, and the
PAC-enabled binary (see tests/testprogs/). The tests will also be run
for this arch.
```
2025-01-22T12:59:32.726079Z INFO lightswitch::profiler: unwinder stats: unwinder_stats_t { total: 44, success_dwarf: 44, error_truncated: 0, error_unsupported_expression: 0, error_unsupported_frame_pointer_action: 0, error_unsupported_cfa_register: 0, error_previous_rsp_zero: 0, error_previous_rip_zero: 0, error_previous_rbp_zero: 0, error_should_never_happen: 0, error_mapping_not_found: 0, error_mapping_does_not_contain_pc: 0, error_chunk_not_found: 0, error_binary_search_exhausted_iterations: 0, error_sending_new_process_event: 0, error_cfa_offset_did_not_fit: 0, error_rbp_offset_did_not_fit: 0, bp_non_zero_for_bottom_frame: 0, vdso_encountered: 0, jit_encountered: 0 }
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the arm64 (aarch64) architecture. This is achived by adapting the compact unwind information generation to deal with the DWARF registers that this architecture maps to and by modifying the unwinder.
These changes support PAC (Pointer Authentication Code), see test plan for more details.
While working on this feature I realised that the vDSO included in Ubuntu 24.10 (6.11.0-12-generic) does not contain unwind information. In the future we should synthetise it which should be easy enough as it seems to be compiled with frame pointers.
Test Plan
Ran tests locally on the arm64 machine mentioned above, and the PAC-enabled binary (see tests/testprogs/). The tests will also be run for this arch.