Increase unwind information batch size #148
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current default might be a bit too conservative on the low side. CPU profiles show quite a bit of time spent calling `update_batch` which should be reduced by increasing the batch size. I considered batches as large as the whole unwind information but these can get quite large in the biggest unwind information buckets, so choosing something between 500k entries or the unwind information length, whichever is smaller. Test Plan ========= ci
javierhonduco
force-pushed
the
increase-unwind-info-batch-size
branch
from
9d7533b to
24fc20c
Compare
javierhonduco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default might be a bit too conservative on the low side. CPU profiles show quite a bit of time spent calling
update_batchwhich should be reduced by increasing the batch size. I considered batches as large as the whole unwind information but these can get quite large in the biggest unwind information buckets, so choosing something between 500k entries or the unwind information length, whichever is smaller.Test Plan
ci