Use the right register type in arm64 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we were using thhe x86 one, `bpf_user_pt_regs_t` is defined in vmlinux as: ``` typedef struct pt_regs bpf_user_pt_regs_t; ``` in x86 and: ``` typedef struct user_pt_regs bpf_user_pt_regs_t; ``` in arm64 Future work =========== Ensure `retrieve_task_registers` is correct for arm64. Test Plan ========= Tested on my x86 and arm64 machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we were using thhe x86 one,
bpf_user_pt_regs_tis defined in vmlinux as:in x86 and:
in arm64
Future work
Ensure
retrieve_task_registersis correct for arm64 and add kernel tests for this architecture.Test Plan
Tested on my x86 and arm64 machines.