Migrate from deprecated Deno APIs.

jaydenseric · Jan 19, 2025 · 8107e75 · 8107e75
1 parent 25cddb2
commit 8107e75
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -14,6 +14,9 @@
   `Deno.serve`.
 - Migrated from the deprecated Deno standard library function
   `readableStreamFromReader` to the new Deno API `Deno.FsFile.readable`.
+- Migrated from the deprecated Deno APIs `Deno.FsFile.rid`, `Deno.resources`,
+  and `Deno.close` to manually calling the modern `Deno.FsFile` method
+  `Symbol.dispose`.
 
 ### Patch
 

diff --git a/publicFileResponse.mjs b/publicFileResponse.mjs
@@ -76,9 +76,9 @@ export default async function publicFileResponse(
 
     return new Response(file.readable, responseInit);
   } catch (error) {
-    // Avoid closing an already closed file, see:
-    // https://github.com/denoland/deno/issues/14210
-    if (file.rid in Deno.resources()) Deno.close(file.rid);
+    // Safely ensure the file is closed, see:
+    // https://github.com/denoland/deno/issues/14210#issuecomment-2600381752
+    file[Symbol.dispose]();
 
     throw error;
   }