Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate OAuthLibMixin from base classes #1191

Merged
merged 2 commits into from
May 7, 2024

Conversation

fdemmer
Copy link
Contributor

@fdemmer fdemmer commented Aug 4, 2022

Description of the Change

The generic view classes ProtectedResourceView and ClientProtectedResourceView inherit from ProtectedResourceMixin and ClientProtectedResourceMixin respectively, which both inherit OAuthLibMixin already.

It seems redundant to me to have the views inherit OAuthLibMixin again.

If there is no reason I am missing, this PR fixes that.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@fdemmer fdemmer requested a review from a team August 4, 2022 14:41
@fdemmer fdemmer self-assigned this Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (560f84d) to head (3dc00f6).
Report is 2 commits behind head on master.

❗ Current head 3dc00f6 differs from pull request most recent head 971e6ba. Consider uploading reports for the commit 971e6ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
- Coverage   97.56%   97.54%   -0.02%     
==========================================
  Files          32       32              
  Lines        2132     2120      -12     
==========================================
- Hits         2080     2068      -12     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdemmer fdemmer removed their assignment Aug 6, 2022
Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dopry dopry force-pushed the fix-view-inheritance branch from ecd5afe to 28b2c7e Compare May 20, 2023 23:59
@n2ygk n2ygk added this to the Future milestone May 31, 2023
@dopry dopry force-pushed the fix-view-inheritance branch 2 times, most recently from c00d73d to 4de280a Compare November 10, 2023 20:43
@dopry dopry force-pushed the fix-view-inheritance branch from 4de280a to 3dc00f6 Compare November 25, 2023 17:09
@n2ygk n2ygk merged commit 0aa27a0 into jazzband:master May 7, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants