Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range of allowed django versions #1547

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix range of allowed django versions #1547

merged 2 commits into from
Jan 29, 2025

Conversation

lullis
Copy link
Contributor

@lullis lullis commented Jan 29, 2025 •
edited by n2ygk
Loading

Fixes #

Description of the Change

Running docker-compose build fails at the moment due to a package resolution conflict. Allowing to use Django 4.2 solves the issue.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@lullis
Fix range of allowed django versions
052014f 
Running `docker-compose build` fails at the moment due to a package
resolution conflict. Allowing to use django 4.2 solves the issue.
n2ygk
n2ygk requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like updates to the version requirements for the test app got missed. Please try with the up to date version requirements.

tests/app/idp/requirements.txt Outdated Show resolved Hide resolved
n2ygk
n2ygk requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I didn't notice on prior review. Please update the intial comment to fill out the pull request template checklist and take all the listed actions. I've edited the comment to include the template.

n2ygk
n2ygk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, this is such a tiny dependency-only change that there's not much to the checklist. Thanks for this.

@n2ygk n2ygk added this to the Release 3.1.0 milestone Jan 29, 2025
@n2ygk n2ygk merged commit 48f4d54 into jazzband:master Jan 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lullis @n2ygk