-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject.toml: add optional dependencies #763
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
==========================================
- Coverage 73.79% 70.44% -3.36%
==========================================
Files 26 26
Lines 1675 1678 +3
==========================================
- Hits 1236 1182 -54
- Misses 439 496 +57 ☔ View full report in Codecov by Sentry. |
Looks good, however I think this deserves a note somewhere in the documentation, probably in installation.rst. |
I tried to write some, but couldn't finish due to my language skills. |
@claudep could you please help with the documentation |
I did not forget you and will return to this as soon as time permits, thanks for your patience! |
I suggest installing this patch:
|
done, thank you |
@claudep added documentation changes per your suggestion. thank you |
Thanks great! I have still one question. Shouldn't we name the optional dependency |
IIRC, there is another backend for imagemagick. |
Ah yes, you're right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR adds support for installing with optional dependencies. Fixes #684