CLOUD-2249 secure routes for basic EAP, JWS and Java templates using … #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luck3y
approved these changes
Apr 9, 2018
maschmid
reviewed
Jun 1, 2018
eap/eap64-amq-persistent-s2i.json
Outdated
| @@ -6,10 +6,10 @@ | |||
| "iconClass": "icon-eap", | |||
| "tags": "eap,javaee,java,jboss", | |||
| "version": "1.4.10", | |||
| "openshift.io/display-name": "JBoss EAP 6.4 + A-MQ (with https)", | |||
| "openshift.io/display-name": "JBoss EAP 6.4 + AMQ (Persistent)", | |||
There was a problem hiding this comment.
should be actually "JBoss A-MQ" as an approved product abbreviation
There was a problem hiding this comment.
I think the hyphen was removed a couple of years ago. Looking at the product page, it appears to be Red Hat AMQ now. I suppose we should get some feedback from the PM.
|
Rebased and removed the A-MQ->AMQ changes from this commit. |
…TLS edge
replace passthrough TLS with edge TLS for ephemeral templates
remove HTTP/S_NAME parameters from basic and ephemeral templates
Signed-off-by: rcernich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…TLS edge
Signed-off-by: rcernich [email protected]