bug(#247): fix all qulice suggestions

jcabi · May 6, 2024 · 475c890 · 475c890
1 parent 46a5182
commit 475c890
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/main/java/com/jcabi/xml/XMLDocument.java b/src/main/java/com/jcabi/xml/XMLDocument.java
@@ -115,6 +115,9 @@ public final class XMLDocument implements XML {
      */
     private final transient Node cache;
 
+    /**
+     * Transformer factory to use for {@link #toString()}.
+     */
     private final transient TransformerFactory tfactory;
 
     static {
@@ -157,7 +160,6 @@ public XMLDocument(final String text) {
         );
     }
 
-
     /**
      * Public ctor, from XML as a text.
      *
@@ -177,7 +179,7 @@ public XMLDocument(final String text) {
      * @param text XML document body
      * @param factory Transformer factory
      */
-    public XMLDocument(final String text, TransformerFactory factory) {
+    public XMLDocument(final String text, final TransformerFactory factory) {
         this(
             new DomParser(XMLDocument.DFACTORY, text).document(),
             new XPathContext(),
@@ -346,6 +348,14 @@ private XMLDocument(
         this(node, ctx, lfe, XMLDocument.TFACTORY);
     }
 
+    /**
+     * Private ctor.
+     * @param cache The source
+     * @param context Namespace context
+     * @param leaf Is it a leaf node?
+     * @param tfactory Transformer factory
+     * @checkstyle ParameterNumberCheck (5 lines)
+     */
     public XMLDocument(
         final Node cache,
         final XPathContext context,

diff --git a/src/test/java/com/jcabi/xml/XMLDocumentTest.java b/src/test/java/com/jcabi/xml/XMLDocumentTest.java
@@ -393,13 +393,13 @@ void comparesDocumentsWithDifferentIndentations() {
         //  different indentations. Don't forget to remove the @Disabled annotation from this test.
         final TransformerFactory factory = TransformerFactory.newInstance(
             "com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl",
-            this.getClass().getClassLoader()
+            Thread.currentThread().getContextClassLoader()
         );
         MatcherAssert.assertThat(
             "Different indentations should be ignored",
-            new XMLDocument("<program>\n  <indentation/>\n</program>", factory),
+            new XMLDocument("<program>\n <indentation/>\n</program>", factory),
             Matchers.equalTo(
-                new XMLDocument("<program>\n          <indentation/>\n</program>\n", factory)
+                new XMLDocument("<program>\n  <indentation/>\n</program>\n", factory)
             )
         );
     }