Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: picker的onchange修改popover demo同步更新 #3025

Merged
merged 58 commits into from
Feb 27, 2025

Conversation

irisSong
Copy link
Collaborator

@irisSong irisSong commented Feb 27, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • Refactor
    • 更新了弹出选择组件的选项数据格式,现在统一显示“标签”和“数值”。
    • 调整了选项变更事件处理逻辑,使数据处理更直观和一致。

@irisSong irisSong requested a review from xiaoyatong February 27, 2025 07:02
@github-actions github-actions bot added 3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (95dc4b8) to head (f9297c5).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3025   +/-   ##
==========================================
  Coverage      85.92%   85.92%           
==========================================
  Files            280      280           
  Lines          18158    18158           
  Branches        2734     2734           
==========================================
  Hits           15603    15603           
  Misses          2550     2550           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoyatong xiaoyatong merged commit 2db1df1 into jdf2e:feat_v3.x Feb 27, 2025
8 checks passed
Copy link

coderabbitai bot commented Feb 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

此次变更主要对 Picker 组件的选项数据结构和事件处理方式进行了调整。在多个 demo 文件中,移除了 PickerOption 接口,将原先使用 text 属性定义选项的方式改为使用 label 属性。同时,组件的事件回调函数也进行了更新:原先直接接收数组参数的 onChange 现在改为接收解构后的对象 { selectedOptions },而 onConfirm 中同样由 text 替换为 label。这些改动发生在 h5 与 taro 两个平台的相关 demo 文件中。

Changes

文件 更改摘要
src/packages/popover/demos/h5/demo4-1.tsx
src/packages/popover/demos/h5/demo4.tsx
移除 PickerOption 接口;将 columns 数组中选项属性由 text 改为 label;更新 onChangeonConfirm 回调参数处理逻辑。
src/packages/popover/demos/taro/demo4-1.tsx
src/packages/popover/demos/taro/demo4.tsx
移除 PickerOption 接口;调整 columns 数组结构由 textlabel 的转换;更新 onChange 回调为解构参数 { selectedOptions }

Sequence Diagram(s)

sequenceDiagram
    participant 用户 as 用户
    participant 选择器 as Picker组件
    participant 处理器 as 事件处理器

    用户->>选择器: 选择某个选项
    选择器->>处理器: 调用 onChange({ selectedOptions })
    处理器->>选择器: 根据 selectedOptions 更新状态

    用户->>选择器: 确认所选项
    选择器->>处理器: 调用 onConfirm(拼接选项 label)
Loading

Possibly related PRs

Suggested reviewers

  • xiaoyatong
  • Alex-huxiyang

Poem

我是一只跳跃的小兔,
在代码丛中轻轻跃动,
每个 label 替代了旧时的 text
每次 onChange 都如新春的晨曦,
我用萝卜般的热情庆祝这清新的更新!
Hop hop,代码世界更美好!
🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95dc4b8 and f9297c5.

📒 Files selected for processing (4)
  • src/packages/popover/demos/h5/demo4-1.tsx (2 hunks)
  • src/packages/popover/demos/h5/demo4.tsx (3 hunks)
  • src/packages/popover/demos/taro/demo4-1.tsx (3 hunks)
  • src/packages/popover/demos/taro/demo4.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai bot mentioned this pull request Feb 28, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants