feat: 类型规范化 #3034

oasis-cloud · 2025-03-03T02:06:05Z

No description provided.

# Conflicts: # src/packages/datepicker/datepicker.taro.tsx # src/packages/datepicker/datepicker.tsx # src/packages/indicator/indicator.taro.tsx # src/packages/picker/index.taro.ts # src/packages/picker/index.ts # src/packages/picker/picker.taro.tsx # src/packages/picker/picker.tsx # src/packages/picker/types.ts

coderabbitai · 2025-03-03T02:06:13Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-03-03T02:07:37Z

Codecov Report

Attention: Patch coverage is 99.32886% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (6697e45) to head (f091808).

Files with missing lines	Patch %	Lines
src/packages/swipe/swipe.tsx	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           feat_v3.x    #3034   +/-   ##
==========================================
  Coverage      86.05%   86.05%           
==========================================
  Files            281      281           
  Lines          18255    18258    +3     
  Branches        2749     2749           
==========================================
+ Hits           15709    15712    +3     
  Misses          2541     2541           
  Partials           5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

irisSong · 2025-03-03T08:52:52Z

src/packages/infiniteloading/index.ts

@@ -1,5 +1,4 @@
 import { InfiniteLoading } from './infiniteloading'

-export type { InfiniteLoadingType } from './types'
-export type { InfiniteLoadingProps } from './infiniteloading'
+export type { InfiniteLoadingType, WebInfiniteLoadingProps } from '@/types'


WebInfiniteLoadingProps 修改

irisSong · 2025-03-03T08:53:50Z

src/packages/infiniteloading/index.taro.ts

@@ -1,4 +1,4 @@
 import { InfiniteLoading } from './infiniteloading.taro'

-export type { InfiniteLoadingProps } from './infiniteloading.taro'
+export type { InfiniteLoadingType, TaroInfiniteLoadingProps } from '@/types'


TaroInfiniteLoadingProps 需要修改为InfiniteLoadingProps 吗

irisSong · 2025-03-03T08:54:56Z

src/packages/navbar/index.ts

@@ -1,4 +1,4 @@
 import { NavBar } from './navbar'

-export type { NavBarProps } from './navbar'
+export type { WebNavBarProps } from '@/types'


导出修改

irisSong · 2025-03-03T08:55:04Z

src/packages/navbar/index.taro.ts

@@ -1,4 +1,4 @@
 import { NavBar } from './navbar.taro'

-export type { NavBarProps } from './navbar.taro'
+export type { TaroNavBarProps } from '@/types'


导出修改

irisSong · 2025-03-03T08:55:59Z

src/packages/progress/index.ts

@@ -1,4 +1,4 @@
 import { Progress } from './progress'

-export type { ProgressProps } from './progress'
+export type { WebProgressProps } from '@/types'


导出修改

irisSong · 2025-03-03T08:58:20Z

src/packages/steps/index.taro.ts

@@ -1,4 +1,4 @@
 import { Steps } from './steps.taro'

-export type { StepsProps } from './steps.taro'
+export type { TaroStepsProps } from '@/types'


导出修改

irisSong · 2025-03-03T08:58:37Z

src/packages/sticky/index.ts

@@ -1,4 +1,4 @@
 import { Sticky } from './sticky'

-export type { StickyProps } from './sticky'
+export type { WebStickyProps } from '@/types'


导出修改

irisSong · 2025-03-03T08:58:52Z

src/packages/sticky/index.taro.ts

@@ -1,4 +1,4 @@
 import { Sticky } from './sticky.taro'

-export type { StickyProps } from './sticky.taro'
+export type { TaroStickyProps } from '@/types'


导出修改

irisSong · 2025-03-03T08:59:22Z

src/packages/swiper/index.ts

 import SwiperItem from '@/packages/swiperitem'
-import { SwiperRef } from '@/packages/swiper/types'
+import { SwiperRef, WebSwiperProps } from '@/types'


导出修改

irisSong · 2025-03-03T08:59:57Z

src/packages/tabpane/tabpane.taro.tsx

@@ -1,27 +1,20 @@
 import React, { FunctionComponent } from 'react'
 import classNames from 'classnames'
 import { View } from '@tarojs/components'
+import { TaroTabPaneProps } from '@/types'


导出修改

oasis-cloud added 12 commits February 26, 2025 16:53

fix: 增加导出的类型

0a1a27e

fix: 增加导出的类型

d4be00a

feat: update spec

70b3743

Merge branch 'feat_v3.x' into feat_types_spec

facdcdc

feat: update spec

e639749

feat: update spec

b727d53

feat: update spec

4740195

feat: update spec

d983ccd

feat: update spec

0c3e084

feat: update sepc

80fdfae

feat: update sepc

f091808

github-actions bot added 3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) labels Mar 3, 2025

oasis-cloud requested review from Alex-huxiyang, xiaoyatong and irisSong and removed request for Alex-huxiyang and xiaoyatong March 3, 2025 02:34

irisSong requested changes Mar 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 类型规范化 #3034

feat: 类型规范化 #3034

oasis-cloud commented Mar 3, 2025

coderabbitai bot commented Mar 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

irisSong Mar 3, 2025

feat: 类型规范化 #3034

Are you sure you want to change the base?

feat: 类型规范化 #3034

Conversation

oasis-cloud commented Mar 3, 2025

coderabbitai bot commented Mar 3, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Mar 3, 2025

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)