Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): add lychee to registry #4181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eread
Copy link

@eread eread commented Jan 23, 2025

Adds lychee (https://github.com/lycheeverse/lychee) to the mise registry.

lychee is already in the aqua registry: https://github.com/aquaproj/aqua-registry/tree/main/pkgs/lycheeverse/lychee

@eread
Copy link
Author

eread commented Jan 23, 2025

@jdx Could you review this one and give me a hand with it? The test appears to be failing mostly because the tags for the lychee project aren't typical (just a version number): https://github.com/lycheeverse/lychee/tags.

Is there a way to customise it in the registry, or does the test need to change?

@eread
Copy link
Author

eread commented Jan 23, 2025

@jdx Could you review this one and give me a hand with it? The test appears to be failing mostly because the tags for the lychee project aren't typical (just a version number): https://github.com/lycheeverse/lychee/tags.

Is there a way to customise it in the registry, or does the test need to change?

@jdx It might be similar to #3684

CC @risu729

@risu729
Copy link
Contributor

risu729 commented Jan 23, 2025

Yeah it seems the same issue. I didn't have time to work on the issue, so I'm just using the ubi backend.

@eread
Copy link
Author

eread commented Jan 23, 2025

Yeah it seems the same issue. I didn't have time to work on the issue, so I'm just using the ubi backend.

@risu729 My failing test seems to be calling aqua:lycheeverse/[email protected], which is correct. However, mise makes a call to https://api.github.com/repos/lycheeverse/lychee/releases/tags/vlychee-v0.18.0 which is almost perfect, but needs to be https://api.github.com/repos/lycheeverse/lychee/releases/tags/lychee-v0.18.0.

CC @jdx

@eread eread force-pushed the eread/add-lychee-to-mise-registry branch from ad72032 to cc77856 Compare January 29, 2025 03:26
@eread
Copy link
Author

eread commented Jan 29, 2025

@suzuki-shunsuke Is this one you're able to help with? 🙇🏻

This is a second attempt (first attempt: #3684) to consume the aqua registry for lycheeverse/lychee, which was added to the aqua registry in aquaproj/aqua-registry#30039.

@suzuki-shunsuke
Copy link

suzuki-shunsuke commented Jan 29, 2025

Before asking me for help, could you keep these documents in mind?

I haven't understood the problem well, but I guess this is mise specific problem.
If so, it's hard for me to help you because I'm not familiar with mise. 🙇‍♂️
If you still need my help, could you elaborate what you ask me?
Do you need any modification of aqua-registry?

@eread
Copy link
Author

eread commented Jan 29, 2025

Before asking me for help, could you keep these documents in mind?

I haven't understood the problem well, but I guess this is mise specific problem. If so, it's hard for me to help you because I'm not familiar with mise. 🙇‍♂️ If you still need my help, could you elaborate what you ask me? Do you need any modification of aqua-registry?

@suzuki-shunsuke Ah, I apologise for reaching out. The reason I thought you might've been able to help was based on #3684 (comment), where it looked like an aqua registry change might be in order. I tried to reproduce a fix locally but wasn't able to.

You had done a lot of the work to make aquaproj/aqua-registry#30039 mergeable, so I thought you might be very familiar with that configuration and possible updates to it.

All of that said, I wasn't aware that mise users looking for help from you was common, and apologise again 🙇🏻

@jdx
Copy link
Owner

jdx commented Jan 29, 2025

I don't believe it's possible for mise to be able to use the "version_filter" property in aqua effectively. I would try to see if you can use version_prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants