-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): add lychee to registry #4181
base: main
Are you sure you want to change the base?
Conversation
317e750
to
ad72032
Compare
@jdx Could you review this one and give me a hand with it? The test appears to be failing mostly because the tags for the Is there a way to customise it in the registry, or does the test need to change? |
@jdx It might be similar to #3684 CC @risu729 |
Yeah it seems the same issue. I didn't have time to work on the issue, so I'm just using the ubi backend. |
@risu729 My failing test seems to be calling CC @jdx |
ad72032
to
cc77856
Compare
@suzuki-shunsuke Is this one you're able to help with? 🙇🏻 This is a second attempt (first attempt: #3684) to consume the aqua registry for |
Before asking me for help, could you keep these documents in mind?
I haven't understood the problem well, but I guess this is mise specific problem. |
@suzuki-shunsuke Ah, I apologise for reaching out. The reason I thought you might've been able to help was based on #3684 (comment), where it looked like an aqua registry change might be in order. I tried to reproduce a fix locally but wasn't able to. You had done a lot of the work to make aquaproj/aqua-registry#30039 mergeable, so I thought you might be very familiar with that configuration and possible updates to it. All of that said, I wasn't aware that |
I don't believe it's possible for mise to be able to use the "version_filter" property in aqua effectively. I would try to see if you can use version_prefix |
Adds
lychee
(https://github.com/lycheeverse/lychee) to themise
registry.lychee
is already in the aqua registry: https://github.com/aquaproj/aqua-registry/tree/main/pkgs/lycheeverse/lychee