Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path option should take precedence over global configuration #4249

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

roele
Copy link
Contributor

@roele roele commented Jan 28, 2025

Fixes #4244 and issue mentioned in #4211

@roele roele force-pushed the issues/use-path-option branch from 15796be to 6b79a23 Compare January 28, 2025 13:25
@jdx
Copy link
Owner

jdx commented Jan 28, 2025

We definitely need e2e tests or this will regress again

@roele roele force-pushed the issues/use-path-option branch 2 times, most recently from 40cab9b to 18ef976 Compare January 28, 2025 22:07
@roele roele force-pushed the issues/use-path-option branch from 18ef976 to 29155bd Compare January 28, 2025 22:17
@jdx jdx merged commit f342d0a into jdx:main Jan 29, 2025
18 checks passed
@roele roele deleted the issues/use-path-option branch January 29, 2025 12:29
jdx pushed a commit that referenced this pull request Jan 29, 2025
### 🚀 Features

- **(registry)** add duckdb by [@swfz](https://github.com/swfz) in
[#4248](#4248)

### 🐛 Bug Fixes

- Swift on Ubuntu 24.04 arm64 generates the incorrect download URL by
[@spyder-ian](https://github.com/spyder-ian) in
[#4235](#4235)
- Do not attempt to parse directories by
[@adamcohen2](https://github.com/adamcohen2) in
[#4256](#4256)
- path option should take precedence over global configuration by
[@roele](https://github.com/roele) in
[#4249](#4249)

### 📚 Documentation

- Add devtools.fm episode about mise to external-resources.md by
[@CanRau](https://github.com/CanRau) in
[#4253](#4253)
- Update sections about idiomatic version files by
[@hverlin](https://github.com/hverlin) in
[#4252](#4252)

### Chore

- make self_update optional by [@jdx](https://github.com/jdx) in
[#4230](#4230)
- added some defaul reqwest features by [@jdx](https://github.com/jdx)
in [#4232](#4232)

### New Contributors

- @adamcohen2 made their first contribution in
[#4256](#4256)
- @CanRau made their first contribution in
[#4253](#4253)
- @spyder-ian made their first contribution in
[#4235](#4235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mise use --env env ... will create a new mise.env.toml file even if .mise.env.toml already exists
2 participants