Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(schema): fix description of task.dir default #4324

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

risu729
Copy link
Contributor

@risu729 risu729 commented Feb 6, 2025

Resolves #4323. Since the default is explained by default property, just remove it from the description.

@JanPokorny
Copy link

@risu729 Not sure if removing is the correct step, since that description is used as a tooltip in VSCode where the default is not visible otherwise:
image

@risu729
Copy link
Contributor Author

risu729 commented Feb 6, 2025

Oh sorry, I didn't notice that. Thanks for letting me know!

@risu729 risu729 marked this pull request as draft February 6, 2025 13:32
@risu729 risu729 changed the title docs(schema): remove wrong default from description of task.dir docs(schema): fix description of task.dir default Feb 6, 2025
@risu729 risu729 force-pushed the remove-wrong-schema-desc branch from 3604baa to 449b83e Compare February 6, 2025 13:34
@risu729
Copy link
Contributor Author

risu729 commented Feb 6, 2025

I synced the description with the docs.

@risu729 risu729 marked this pull request as ready for review February 6, 2025 14:45
@jdx jdx enabled auto-merge (squash) February 6, 2025 14:49
@jdx jdx merged commit 62f4ca0 into jdx:main Feb 6, 2025
18 checks passed
@risu729 risu729 deleted the remove-wrong-schema-desc branch February 8, 2025 02:10
roele pushed a commit to roele/mise that referenced this pull request Feb 8, 2025
Resolves jdx#4323. Since the default is explained by `default` property,
just remove it from the `description`.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
jdx pushed a commit that referenced this pull request Feb 8, 2025
### 🚀 Features

- **(registry)** add jd by [@risu729](https://github.com/risu729) in
[#4318](#4318)
- **(registry)** add jc by [@risu729](https://github.com/risu729) in
[#4317](#4317)
- **(registry)** Add qsv cli by [@vjda](https://github.com/vjda) in
[#4334](#4334)
- add support for idiomatic go.mod file by
[@roele](https://github.com/roele) in
[#4312](#4312)
- add -g short version for unuse cmd by
[@kimle](https://github.com/kimle) in
[#4330](#4330)
- add git remote task provider by [@acesyde](https://github.com/acesyde)
in [#4233](#4233)
- set usage arguments and flags as environment variables for toml tasks
by [@gturi](https://github.com/gturi) in
[#4159](#4159)

### 🐛 Bug Fixes

- **(aqua)** trim prefix before comparing versions by
[@risu729](https://github.com/risu729) in
[#4340](#4340)
- wrong config file type for rust-toolchain.toml files by
[@roele](https://github.com/roele) in
[#4321](#4321)

### 🚜 Refactor

- **(registry)** use aqua for yq by [@scop](https://github.com/scop) in
[#4326](#4326)

### 📚 Documentation

- **(schema)** fix description of task.dir default by
[@risu729](https://github.com/risu729) in
[#4324](#4324)
- Add PowerShell example by [@jahanson](https://github.com/jahanson) in
[#3857](#3857)
- Include "A Mise guide for Swift developers" by
[@pepicrft](https://github.com/pepicrft) in
[#4329](#4329)
- Update documentation for core tools by
[@hverlin](https://github.com/hverlin) in
[#4341](#4341)
- Update vitepress to fix search by
[@hverlin](https://github.com/hverlin) in
[#4342](#4342)

### Chore

- **(bun.lock)** migrate bun lockfiles to text-based by
[@risu729](https://github.com/risu729) in
[#4319](#4319)

### New Contributors

- @vjda made their first contribution in
[#4334](#4334)
- @kimle made their first contribution in
[#4330](#4330)
- @pepicrft made their first contribution in
[#4329](#4329)
- @jahanson made their first contribution in
[#3857](#3857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants